search

ProtonMail / proton-bridge

Proton Mail Bridge application
GNU General Public License v3.0
1.15k stars 156 forks source link

"Hello!" being randomly printed in the cli interface #479

Open Aadniz opened 4 months ago

Aadniz commented 4 months ago

When starting protonmail bridge with the -c argument and starting syncing, the word "hello!" keeps showing up. It brings no info to the user whatsoever, it's only taking up space.

image

It is caused by the code execution landing here https://github.com/ProtonMail/proton-bridge/blob/b84663dd7ab7ba891fe795e7c5681a48ab32f2fe/internal/frontend/cli/frontend.go#L495-L497

Expected Behavior

The expected behavior is showing what the actual issue is, instead of just printing a static word. events.Raise should return a message that explains the error.

Current Behavior

Application randomly prints "Hello!"

Possible Solution

Several solutions. Fastest is removing the code at https://github.com/ProtonMail/proton-bridge/blob/b84663dd7ab7ba891fe795e7c5681a48ab32f2fe/internal/frontend/cli/frontend.go#L496

The proper way may be altering the frontendCLI struct

Steps to Reproduce

1. 2. 3. 4.

Version Information

Version: 3.11.1

Context (Environment)

Detailed Description

Possible Implementation