ProtonMail / proton-contacts

React web application to manage ProtonMail contacts
54 stars 19 forks source link

Prevent phantom requests when clicking on contacts with no image #315

Closed econdepe closed 4 years ago

econdepe commented 4 years ago

When clicking on a contact with no image, there was a request to localhost/undefined. Somehow this was generated by the helper toImage when passed an undefined argument, which was happening in the ContactImageSummary component. This has been fixed in https://github.com/ProtonMail/proton-shared/pull/70

Additionally, the images were loaded before the "Load Image" button was clicked, which should not be the case.