search

ProtonMail / proton-contacts

React web application to manage ProtonMail contacts
54 stars 19 forks source link

Off by 1 error when reporting validation issues during import #348

Closed DeepSpaceHarbor closed 3 years ago

DeepSpaceHarbor commented 4 years ago

Steps to reproduce

  1. Go to contacts
  2. Delete all contacts
  3. Import big cvs file, which contains some email validation errors. If you don't have such file, contact me, I can provide one.
  4. In the error messages, notice how the contact order doesn't match the invalid field in the csv file.

Current behavior image

The error says: Contact 8188 from your list could not be imported. Email address failed validation but looking at the csv file, rows 8188 and 8189 are ok. The issue seems to be in row 8190.

image

Expected behavior The error should be: Contact 8189 from your list could not be imported. Email address failed validation