Missing warning when the contact key is expired or revoked

ProtonMail / proton-contacts

React web application to manage ProtonMail contacts

54 stars 19 forks source link

Missing warning when the contact key is expired or revoked #355

Closed DeepSpaceHarbor closed 4 years ago

DeepSpaceHarbor commented 4 years ago

Steps to reproduce

Open contact with expired or revoked key
Open advanced settings

Expected behavior Notification about expired or revoked key. This is what we have in v3:

Current behavior This warning is missing. I don't see any mention of expired or revoked key.

econdepe commented 4 years ago

This problem only appears for contacts with corrupted vcards, with a KEY field but nothing on it. For contacts with expired keys in the vcard, the warning is displayed in v4.

I would say this behavior was a bug in v3, since no key would be displayed, but you would still get the toggle for encrypt ON (with which key is that supposed to encrypt?!?) and a message referring to "all uploaded keys"