ProtonMail / proton-contacts

React web application to manage ProtonMail contacts
54 stars 19 forks source link

Add input validation to Addresses #385

Open jwflory opened 4 years ago

jwflory commented 4 years ago

Tested on 4.0.0-beta.11.

Summary

Add simple input validation for Addresses to save information consistently across multiple contacts.

Background

I first experienced this need when using the Contact Merge feature in Proton Contacts.

Sometimes the Contact Merge duplicates a contact's address multiple times in a contact. I use the Contact Import feature on Android often, since Proton Contacts is not my default contact book yet, but I am planning to transition eventually (so I want information to be current on both). After I re-upload contacts, I go through and merge duplicates to clean up.

Sometimes a contact has an address written two ways:

1.

123 Any Street
Cityville, New York 55555
United States

2.

123 Any Street
Cityville, New York 55555
USA

This results in the contact having two addresses that are actually the exact same, minus one minor detail.

Details

Avoid duplicate addresses by validating the user's input and using a common standard for information like Country Names, State Names, or Regions. This would help me maintain my contact metadata more easily as I prepare to transition.

Outcome

Avoid creating duplicate data when there are subtle differences between addresses (e.g. United States and US)