Add conversation view - Githubissues

ProtonMail / proton-mail

React web application to manage ProtonMail

https://beta.protonmail.com

GNU General Public License v3.0

178 stars 26 forks source link

Add conversation view #3

Open EpokK opened 5 years ago

Swiip commented 4 years ago

Manager: @matstaz QA: @DaraQA Test server: https://tartiflette.protonmail.blue/ Test account: all 🎉 API: blue

What could be seen:

List panel containing messages or conversations
Paging
Sorting (time or size, asc or desc)
Filtering (read or unread)
Conversation or message mode
Column or row mode
Cache on page navigation (unless pages are not consecutive)
Cache on message displayed
Listen to API event system to update view on message or conversation changes
Move to folder and add label actions
Fix navigation and URL management
Page title update
Element selection
Different panels: empty, welcome, selection

What could not be seen:

Opening every kind of message
Search
Composer

DeepSpaceHarbor commented 4 years ago

Summary The info panel on the right side is not updated.

Steps to reproduce

Login
Go to different folder.
Notice how the panel on the right is not changed.

Screenshot

DeepSpaceHarbor commented 4 years ago

Summary The app can't recover from invalid conversation id state.

Steps to reproduce

Login
Go to https://tartiflette.protonmail.blue/inbox/aaaaaaaaaaaaaaaaaaaaaaaaa
Click inbox (or other folder) on left menu

Expected behavior I should be in the selected folder.

Current behavior Nothing happens.

DeepSpaceHarbor commented 4 years ago

Summary Check new mail icon is not animated.

Current behavior

Expected behavior

DeepSpaceHarbor commented 4 years ago

Summary Drag n drop into label or folder is not supported.

Steps to reproduce

Login
Drag a message to custom folder or label.

Expected behavior

Dragging message to custom folder should move the message to the selected folder.
Dragging messages to a label, should apply the selected label.

DeepSpaceHarbor commented 4 years ago

Summary The design for labels doesn't match the current beta.

Current behavior

Expected

Swiip commented 4 years ago

Thanks @DeepSpaceHarbor for the feedbacks. Some was known, some are new. I created issues to track each:

Update counters of the welcome panel #42
Handle wrong urls #20
Force refresh when clicking on the current label in the menu #43
Support for drag and drop for message/conversation to label/folder #44
Display labels #7

DeepSpaceHarbor commented 4 years ago

Summary App crash when creating new label & folder.

Steps to reproduce

Open any message
Open label dropdown
Create new label

Current behavior App crash.

Video https://recordit.co/2jtiNzrJi6

DeepSpaceHarbor commented 4 years ago

Steps to reproduce

Open any message
Open label or folder dropdown
Type random string to show the error message.
Click on add new label/folder button.

Expected behavior Modal for new label/folder should be shown. The name input should be the same from the dropdown.

Current behavior When the modal is opened, the name input field is empty.

DeepSpaceHarbor commented 4 years ago

Summary In the current beta, the labels dropdown is always shown bellow the add label button. In the react version, is looks like the dropdown can be also shown on the left side. is this expected behavior?

Screenshots

DeepSpaceHarbor commented 4 years ago

Summary Missing error message when invalid folder name is used in move to dropdown.

Screenshot

Swiip commented 4 years ago

I created the new issues directly in Jira