Refactor attachments logic

ProtonMail / proton-mail

React web application to manage ProtonMail

https://beta.protonmail.com

GNU General Public License v3.0

178 stars 26 forks source link

Refactor attachments logic #35

Closed Swiip closed 4 years ago

Swiip commented 4 years ago

Fix #30

[x] Decrypt MIME messages
[x] Fix MIME attachments
[x] Refacto attachment operations
[x] Refacto embedded operations
[x] Try to reuse some Angular test

Swiip commented 4 years ago

I struggled a lot with TypeScript and some crashes without any hints and no documentations but I finally make it.

I imported openpgp typings and used it to type what I use of pmcrypto. It could help a lot in the future to properly type all cryptography related data structures!