search

ProtonMail / proton-mail

React web application to manage ProtonMail
https://beta.protonmail.com
GNU General Public License v3.0
178 stars 26 forks source link

Make it possible to build project on node.js v16 #74

Open vladimiry opened 3 years ago

vladimiry commented 3 years ago

Currently npm ci step gets failed on node.js v16 during rebuilding sharp native module.

Upgrading sharp version in proton-pack#favicons-webpack-plugin#favicons and proton-pack#sharp chains is likely going to help, see https://github.com/lovell/sharp/issues/2611.

dhoko commented 3 years ago

On our side, we only validate things for the latest LTS (v14). Compat with the new LTS will be done before the v16 becomes the LTS. It should be available during summer I think :thinking:

(Depends if the support breaks something for v14 or we can have it for both, LTS is more important than v16)

vladimiry commented 3 years ago

Yep, I understand the LTS matter. Just wanted to highlight that updating sharp version will fix the issue when running on node.js v16.