ProtonVPN / android-app

Official ProtonVPN Android app
https://protonvpn.com/download-android
GNU General Public License v3.0
2.04k stars 278 forks source link

F-Droid can't build #103

Closed licaon-kter closed 1 year ago

licaon-kter commented 1 year ago

Updating recipe, to remove the swan part...

  - versionName: 4.4.73.0
    versionCode: 104047300
    commit: 0dfed59817a87e1d63cb72230cec6d18f3c944b5
    timeout: 7200
    subdir: app
    sudo:
      - apt-get update
      - apt-get install -y --no-install-recommends make libgmp-dev autoconf automake
        libtool pkg-config autogen gettext libssl-dev libsqlite3-dev libpam0g-dev
        libldap2-dev gperf bison bzip2 flex swig cmake
    gradle:
      - prod
    rm:
      - app/src/main/jniLibs/x86/*
      - app/src/main/jniLibs/x86_64/*
      - app/src/main/jniLibs/armeabi-v7a/*
      - app/src/main/jniLibs/arm64-v8a/*
      - openvpn/src/main/cpp/mbedtls/tests
      - openvpn/src/main/cpp/openvpn3/test/unittests
      - openvpn/src/main/cpp/mbedtls/programs/fuzz/corpuses/*
    prebuild:
      - sed -i -e '/triple/d' -e '/play\ {/,+4d' build.gradle
      - sed -i -e '/gradle-build-cache/d' ../settings.gradle.kts
    scandelete:
      - openvpn/src/main/cpp/lz4/tmp
    build:
      - pushd ../openvpn
      - gradle assembleRelease
      - rm -fr build/intermediates build/kotlin build/tmp .cxx
      - popd
    ndk: r23b
    gradleprops:
      - buildUniversalApk

but... now I'm missing some libs in the APK: libipsec.so and libtncif.so

Thoughts?

AlgirdasPundzius commented 1 year ago

Hello @licaon-kter Libs are actually remnant leftover of IKEv2, which we missed to remove. They are no longer used (will be removed in future releases)

licaon-kter commented 1 year ago

Great: https://gitlab.com/fdroid/fdroiddata/-/commit/fdecf16cdf0b4556afe69b5508d6c46b331be363

AlgirdasPundzius commented 1 year ago

@licaon-kter I see the build is still failing :( Tried to look through the logs, but it's not really clear why it's failing, could you take a look and point if there is something we should do ?

licaon-kter commented 1 year ago

It built fine for me locally, will take a second look.

licaon-kter commented 1 year ago

@AlgirdasPundzius where do you see it fail? It will be build in this cycle... https://monitor.f-droid.org/builds/running (last try was on Dec 16 before the fix)

AlgirdasPundzius commented 1 year ago

Maybe it's me misunderstanding fdroid pipelines and all is ok.

It fails in the job you posted before with 3h timeout finally killing the job. https://gitlab.com/fdroid/fdroiddata/-/jobs/3495889474 I've tried to modify the script on my fork and it also failed in similar fashion

I also see the build should've been updated (build for in builds/running ch.protonvpn.android:104047300 == 4.4.73.0) though on web it's still Version 4.3.80.3.

licaon-kter commented 1 year ago

The Gitlab CI is for verification and has it's limits (time, storage, ram, cpus).

The proper buildserver is better, and elsewhere.

The app was build, this cycle has ended, it awaits publishing. Put a bookmark at: https://monitor.f-droid.org/builds/running ;)

AlgirdasPundzius commented 1 year ago

Alright, thanks for explanation :)