search

ProtonVPN / android-app

Official ProtonVPN Android app
https://protonvpn.com/download-android
GNU General Public License v3.0
2.37k stars 310 forks source link

[feature request] allow ip range in split tunneling #37

Open D4nte opened 4 years ago

D4nte commented 4 years ago

Currently, individual IPs needs to be entered in the split tunneling configuration screen.

In addition to that, we should be able to enter an IP network range such as 192.168.0.0/24. This would allow split tunnelling on all devices of a specific network, instead of entering addresses one by one.

heiserhorn commented 4 years ago

Yes this would be very useful for local network.

tlundgren commented 3 years ago

In case it is of helpt to Proton. Very roughly, a possibility for allowing the use of sub nets is to...

  1. Change editIP edit text in layout dialog_split_tunneling.xml to allow users to specify both IP addresses and sub nets in CIDR format (eg 192.168.1.0/24).
  2. Change editIP.addTextChangedListener in class IpDialog so that the listener verifies that the input (editable.toString()) is a valid address or sub net, not just an individual address.
  3. Change class UserData: 1) add a new attribute of type List just like splitTunnelIpAddresses, lets call it splitTunnelIps, to hold the addresses and sub nets the user introduces via IpDialog. 2) Change current splitTunnelIpAddresses attribute so that now it is the result of the explosion of splitTunnelIps, ie it represents all the individual Ip addresses that derive from the addresses and sub nets in splitTunnelIps.
  4. Change class IpAdapter so that the data displayed by the recycler view be not UserData.splitTunnelIpAddresses, but the new attribute, UserData.splitTunnelIps.

This would make it possible for users to work with individual addresses and sub nets while requiring code changes only in the split tunneling feature. Still, it may be possible to use sub nets in the VPNProfile classes of IKEv2 and OpenVPN (the classes that take the excluded Ip addresses from UserData so that they are actually excluded from the VPN). Indeed, according to its documentation, IKEv2 seems to support sub nets in the profile directly.

Additionally, some new decisions would have to be made with regards to Ip address/sub net inputs. If, presently, a valid input is a correctly formatted Ip address that is not already excluded, with this change, a valid input may be: a correctly formatted Ip address that is not already excluded (by means of the same address, or a sub net), and a correctly formatted sub net that does not overlap with another, already excluded, sub net. Additionally, if a sub net includes, in their entirety, an already excluded address or sub net, a dialog could be presented to the user: is it Okay to delete those addresses and sub nets, to add the new sub net? This would ensure that the exclusion list does not contain overlaps. By the way, for doing Ip address and range validations as mentioned above and in points 1, 2, library IPAddress could help. I wrote a small class that makes use of it to make some of those validations, just to provide a basic sample.

ralioc commented 11 months ago

Is there any updates on this? I've been trying to add vudu.com to the tunnel and they apparently have 1024 ip addresses the way I understand it.

What else would be nice is if we can enter a website name instead of IP... that way it would automatically detect the ip from the site. Other vpn services offer this feature, but I prefer proton since I've had the best luck with it.

Gitchick57 commented 11 months ago

This also didn't work for me when I tried to add an app for split tunneling.

Dec 17, 2023, 3:12 AM by @.***:

Is there any updates on this? I've been trying to add vudu.com to the tunnel and they apparently have 1024 ip addresses the way I understand it.

What else would be nice is if we can enter a website name instead of IP... that way it would automatically detect the ip from the site. Other vpn services offer this feature, but I prefer proton since I've had the best luck with it.

— Reply to this email directly, > view it on GitHub https://github.com/ProtonVPN/android-app/issues/37#issuecomment-1859068824> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A6G5JCCE4NY2UQDN6HTFXATYJ2SPRAVCNFSM4RN5WNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVHEYDMOBYGI2A> . You are receiving this because you are subscribed to this thread.> Message ID: > <ProtonVPN/android-app/issues/37/1859068824> @> github> .> com>