search

ProtonVPN / proton-vpn-gtk-app

Official ProtonVPN Linux app
https://protonvpn.com/download-linux
GNU General Public License v3.0
152 stars 20 forks source link

Fix name duplications in feature_settings tests #19

Closed bartsanchez closed 5 months ago

bartsanchez commented 6 months ago

Hello! I've discovered that a couple of tests names were colliding and thus not running properly. I am following the same convention name as the rest of the killswitch tests.

calexandru2018 commented 5 months ago

Hey @bartsanchez , thanks for your PR. We've merged this internally, once we release this fix we'll close your PR and your commit will be in the git history.

bartsanchez commented 5 months ago

@calexandru2018 Excellent, thank you!

calexandru2018 commented 5 months ago

Hey @bartsanchez , thanks again for your contribution. Your fix has been released today: https://github.com/ProtonVPN/proton-vpn-gtk-app/commit/d62659b1f9af3fd325190a13340a2ae4f12e0e53

I'll be closing this PR