search

ProtonVPN / proton-vpn-gtk-app

Official ProtonVPN Linux app
https://protonvpn.com/download-linux
GNU General Public License v3.0
155 stars 20 forks source link

Handle "confirm logout" dialog closure #2

Closed Weilbyte closed 5 months ago

Weilbyte commented 8 months ago

When connected to VPN and a logout is attempted, you will receive a prompt asking you to confirm, as you will be disconnected from the VPN.

Once the logout button is clicked, it is disabled, and in the case that you answer No (that you do not wish to log out) to the prompt, it closes and the button is enabled. However, if you close the prompt (using the X in the top-right), the button is not re-enabled, as the code does not check for Gtk.ResponseType.DELETE_EVENT.

calexandru2018 commented 8 months ago

Hey @Weilbyte and thanks for your contribution! Your MR will be merged into our internal repo first and then will eventually get published with other fixes. Once I close this MR it will mean that your MR has been merged internally. Again thanks for your contribution. :)

calexandru2018 commented 5 months ago

Hey @Weilbyte , thanks for your PR. We've merged this internally, once we release this fix we'll close your PR and your commit will be in the git history.

calexandru2018 commented 5 months ago

Hey @Weilbyte , thanks again for your contribution. Your fix has been released today: https://github.com/ProtonVPN/proton-vpn-gtk-app/commit/7063e01336d7947c1a16bb5b0f3693128761aaef

I'll be closing this PR