ProtonVPN / proton-vpn-gtk-app

Official ProtonVPN Linux app
https://protonvpn.com/download-linux
GNU General Public License v3.0
216 stars 28 forks source link

Add in-tree Flatpak support (are you interested in providing a Flatpak manifest?) #7

Open felipeborges opened 10 months ago

felipeborges commented 10 months ago

I understand if you don't want to commit now to maintaining yet another build specification. :smile:

I was trying your app out and decided the easiest way for me to test the latest commit was with a Flatpak build, so I went ahead and did what I am proposing in this PR regardless. Feel free to close the PR. :grinning:

But if you decide to go in this direction, you'd be great to contact the maintainer of the unofficial ProtonVPN app on Flathub and propose a collaboration. The manifest there could be synced with this one here.

With these files in-tree I was able to open GNOME Builder, enter this repository URL, click Play, wait for the build and success! The app launched!


Add in-tree Flatpak support

I took the Flatpak manifest from https://github.com/flathub/com.protonvpn.www and converted it to JSON for this, so that it can be used by GNOME Builder for local Flatpak builds. Credits to @proletarius101 for the original work!

GNOME Builder only supports the JSON format. Builder is the recommended IDE for developers building GTK and GNOME apps. It has built-in support for Flatpak builds with just a click. https://wiki.gnome.org/Newcomers/BuildProject

Making it easy for the GNOME/GTK community to build your app can attract valuable contributors. This also helps you have reproducible builds across different environments.

In the future, if there's interest, this same Flatpak manifest could be used by a GitHub Action to produce a Flatpak bundle out of a CI job.