search

ProtonVPN / protonvpn-cli

Legacy protonvpn-cli: ProtonVPN Command-Line Tool for Linux and macOS. This has been superseded by https://github.com/ProtonVPN/protonvpn-cli-ng
Other
607 stars 98 forks source link

Fix bug regarding listing servers in Free plan #202

Closed ghost closed 4 years ago

ghost commented 4 years ago

If a user chooses the Free plan, then only countries with free servers are listed by the script: Japan, Netherlands and USA. However when the user selects Japan or Netherlands (s)he gets instead the servers list from Canada or Germany respectively.

This commit fixes the issue.

Tamaranch commented 4 years ago

I can't reproduce this issue. Are you sure of your configuration?

ghost commented 4 years ago

I was porting protonvpn-cli to FreeBSD, so I had to make some changes to the original script to correct things that would work only with Linux and remove things that become unnecessary or even create confusion (FreeBSD, as most Linux, has its own way to create and monitor packages, thus we do not want the script to install, uninstall or update anything and checking for requirements is unnecessary).

Maybe I have modified or removed something and created the bug as a side effect or I missed some "Linuxism".

If anyone else wants to try to reproduce the issue I should add that I tested the release v1.1.2. If nobody can reproduce the issue of course we can close this pull request.

ghost commented 4 years ago

I close the pull request since it seems I was the only one to have the issue. Moreover there was a mistake in my patch (country_id should have been set to 9 instead of 6 and to 6 instead of 7), but since everything is fine for everyone else there is no need to correct it.