ProtonVPN / protonvpn-cli

Legacy protonvpn-cli: ProtonVPN Command-Line Tool for Linux and macOS. This has been superseded by https://github.com/ProtonVPN/protonvpn-cli-ng
Other
604 stars 95 forks source link

Option to install with NetworkManager support on Ubuntu #86

Open markfaine opened 6 years ago

markfaine commented 6 years ago

For example, -init could create NetworkManager vpn configuration files for each of the available servers (/etc/NetworkManager/system-connections) as well as a systemd configuration and start/stop script. That should allow for the normal Ubuntu Network Manager to show when the VPN is connected, and also show which server is connected in the system tray. It would also allow the user to see when they are are connected at a glance. They could then optionally connect to different servers through the Network Manager interface.

mazen160 commented 6 years ago

Hi @markfaine Thanks for your feature request!

Here is what I have in mind based on your plan $ pvpn --import-config It downloads and installs configs for NetworkManager, whenever you click on the network manager, you can just rely on it if you prefer it. It would be separate from protonvpn-cli connections; just importing and confugring everything based on your plan.

Also an option to clear all config.

What do you think?

I'm brainstorimng ideas for the feature:)

Thanks, Mazin

markfaine commented 6 years ago

Sounds like a good idea. This would address an important issue for me, which is the ability to use of the OS user interfaces for VPN, which provides the ability to see that the VPN is connected and to easily switch between servers. However, lately I'm finding that there are some issues with the current implementation of network manager that might need a fix. It seems that it doesn't properly update the resolv.conf on up/down and so there are DNS leaks. I'm thinking about submitting a bug to Ubuntu. Also, I don't know if network manager can prevent any network activity in the event of a dropped connection.

Do you have a server that basically just redirects to the fastest server? I was thinking I'd probably import multiple servers but for day to day use I'd be looking for the fastest server, however, fastest may change from day to day. This could be solved if there was a server that just did a redirect to the fastest server for the user. I'm not seeing very good speeds though even on the fastest server. Connecting to the fastest server I get 10Mbps over WIFI on a 1Gbps network that delivers around 600Mbps (actual) on a wired connection. Disconnected from VPN over WIFI I get ~90Mbps. Any tips? I don't expect anywhere near the same speeds as when I'm disconnected from VPN but it should be better than 10Mbps, shouldn't it?

Thank you, -Mark

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On April 14, 2018 4:50 PM, Mazin Ahmed notifications@github.com wrote:

Hi @markfaine Thanks for your feature request!

Here is what I have in mind based on your plan $ pvpn --import-config It downloads and installs configs for NetworkManager, whenever you click on the network manager, you can just rely on it if you prefer it. It would be separate from protonvpn-cli connections; just importing and confugring everything based on your plan.

Also an option to clear all config.

What do you think?

I'm brainstorimng ideas for the feature:)

Thanks, Mazin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mazen160 commented 6 years ago

Hi Mark,

However, lately I'm finding that there are some issues with the current implementation of network manager that might need a fix. It seems that it doesn't properly update the resolv.conf on up/down and so there are DNS leaks. I'm thinking about submitting a bug to Ubuntu. Also, I don't know if network manager can prevent any network activity in the event of a dropped connection.

It would be better to report it to Ubuntu. The problem that many Linux distros act really weird sometimes. I have seen that during compatibility testing of different distros. The goal of protonvpn-cli initially is to:

Do you have a server that basically just redirects to the fastest server? I was thinking I'd probably import multiple servers but for day to day use I'd be looking for the fastest server, however, fastest may change from day to day. This could be solved if there was a server that just did a redirect to the fastest server for the user.

That's a cool idea, we currently don't have this part, but we provide an API that is used to determine fastest server. But a server that redirects connections is not there. I don't know if it can be implemented correctly, I have forwarded this note to the team.

I'm not seeing very good speeds though even on the fastest server. Connecting to the fastest server I get 10Mbps over WIFI on a 1Gbps network that delivers around 600Mbps (actual) on a wired connection. Disconnected from VPN over WIFI I get ~90Mbps. Any tips? I don't expect anywhere near the same speeds as when I'm disconnected from VPN but it should be better than 10Mbps, shouldn't it?

I'm not sure about this part, I have also forwarded it to the team. You're correct about this, the responsible team will be checking it.

Regarding the feature request, I now have the required ideas, it's added to the roadmap. Thanks for the addition!

Thanks!!

Best, Mazin