Suggestion for One Button menu modification - Gravity Config Menu

[DonSaber]

I hope this is the proper place for a code mod proposal.

I was having hard times with the configuration menu on my saber wired with a single button. Mainly, I was not able to have a double click recognized by the board and configuring the saber was a real pain. Don't know the reason, perhaps i's due to the AV push button I'm using or perhaps it's just me.

So, I decided to modify the way the user interacts with the menu, removing the double click and integrating a kind of Gravity selection mode.

Reusing the code designed to identify the orientation of the saber in the color selection process for string blades, I modified the code to have the following behavior.

• Single click with button facing up -> Increase parameter value (on board, SD card reader facing up)
• Single click with button facing down -> Decrease parameter value (on board, SD card reader facing down)
• Single click with button horizontal facing chest -> Next config menu (on board, SD card reader facing chest)

To get this behavior it's necessary to align the SD card with your switch. On different install layouts it's easy enough to move the functions to other orientations.

The code is modified for the following menu items (only in One Button mode): CS_VOLUME, CS_SOUNDFONT, CS_FLICKERTYPE, CS_MAINCOLOR, CS_CLASHCOLOR, CS_BLASTCOLOR, CS_SWINGSENSITIVITY.

Regarding the modifications to the code I did:

FX-SabersOS int8_t orientation = 0;

Buttons.cpp extern int8_t orientation;

ifdef COLOR_PROFILE

define COLORPROFILES_QUANTITY 14

(I'm showing the color selection routine only, but in the code all indicated menu items are modified in thew same way)

    if (ButtonActionType==SINGLE_CLICK){
  orientation = GravityVector();
      switch (orientation) {
        case (0): // switch oriz back
          NextConfigState();
          break;
        case (1):
          // action
          break;              
        case (2):
          // action
          break;              
        case (3):
          // action
          break;
        case (4): // switch down
          confParseValue(modification, 0, COLORPROFILES_QUANTITY - 1, -1*incrementSign);
          break;
        case (5): // switch up
          confParseValue(modification, 0, COLORPROFILES_QUANTITY - 1, incrementSign);
          break;
      }
        modification = value;
        getColorFix(modification);
    }

I also added the new variable COLORPROFILES_QUANTITY to the color profile selection routine, so it is easier to add or remove color profiles from the list without the need to modify the functions in other places of the code.

I'm attaching the modified files for review. Be kind, it's my first programming since ages and an absolute first with Arduino.

OneButtonGravityConfig.zip

[Protonerd]

This is great! I have been looking for such a solution for a long time now. It was very convenient to have 3 different possibilities to interact with the buttons (click, long press, double click), it opened up the way to include all the functions a saber with two buttons can do. But to be completely honest I'm also a bit uncertain as to whether the double click is a good idea. I would like to replace it completely with a different kind of interaction - let's call it like that - because it's as you rightly said a pain.

I did not consider the method you described although its implementation was lying there all the while. Good work!!!

Some other possibilities:

• it is not really well known, as I never really bothered to document it, but I built in a so called hit-and-run method into the Config Mode. If you make a clash (hit the hilt) in Config mode it will have different effects, mostly it will cause an exit from Config Mode (kind of escape sequence), or like in Volume or Swing Sensitivity settings mode it will increase/decrease values in bigger steps than the click. Therefore a clash would be a candidate to replace double click.
• another idea would be - requiring a rework of the button FSM - to introduce two kinds of long presses, with configurable lengths, like a long press with min 3s and an ultra long press for min 5s.