Color of the Pixel Accent not matching with Pixel Blade (v1.1-beta)

[AirmakZ]

I installed the v1.1-beta to check the pixel accent amazing feature. Taking into account it's just a beta version it working really fine, but I have an strange phenomena....:

The color of the pixel blade is not matching with pixel accent. Basically I have the following relations: Blade: red -> Accent: green Blade: blue -> Accent: blue Blade: green -> Accent: OFF

I don't think it's related with hardware because pixel accent if changing the color properly, even with different brightness level...

Thanks in advanced for your support!

[jbkuma]

Depending on the LED red and green might be swapped, but no color should just not work.

In FXSaberOS.ino, after line 121 WS2812 accentPixels(NUM_ACCENT_PIXELS); add accentPixels.setColorOrderRGB();

I think this should work, but I can't test it. If it works I will update a new version that includes a flag "swapAccentRG" that will make it easier to fix this in the configuration.

Jason "Kuma" Brinkerhoff Mad Science Workshoppe, proprietor http://jbkuma.com/workshoppe

On Fri, Aug 17, 2018 at 5:27 PM AirmakZ notifications@github.com wrote:

I installed the v1.1-beta to check the pixel accent amazing feature. Taking into account it's just a beta version it working really fine, but I have an strange phenomena....:

The color of the pixel blade is not matching with pixel accent. Basically I have the following relations: Blade: red -> Accent: green Blade: blue -> Accent: blue Blade: green -> Accent: OFF

I don't think it's related with hardware because pixel accent if changing the color properly, even with different brightness level...

Thanks in advanced for your support!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Protonerd/FX-SaberOS/issues/76, or mute the thread https://github.com/notifications/unsubscribe-auth/ATdCMB28KKT7KXWaTOF9-3nseZtjBJBxks5uRzU9gaJpZM4WCOHu .

[AirmakZ]

Hi jbkuma, thanks for your quick answer.

Your proposed solution is WORKING FINE !! Just instead of line 122 I added the command inside setup, otherwise I have the compilation error: _FX-SaberOSbeta:121: error: 'accentPixels' does not name a type

void setup() {
  #ifdef PIXEL_ACCENT
    accentPixels.setColorOrderRGB();
    accentPixels.setOutput(PIXEL_ACCENT_DATA);
  #endif

I don't know how the WS2812 library works but taking into account I'm using leds from the same reel... it seems strange.... Anyway.... SOLVED.

Regarding red color issue I will try replacing the led because I unsolder it from the strip and maybe It's damaged.

Thanks again.

[jbkuma]

I added a fix to the main branch with notes on Facebook and Open Saber forum

On Fri, Aug 17, 2018, 7:00 PM AirmakZ notifications@github.com wrote:

Hi jbkuma, thanks for your quick answer.

Your proposed solution is WORKING FINE !! Just instead of line 122 I added the command inside setup, otherwise I have the compilation error: FX-SaberOS_beta:121: error: 'accentPixels' does not name a type

void setup() {

ifdef PIXEL_ACCENT

accentPixels.setColorOrderRGB();
accentPixels.setOutput(PIXEL_ACCENT_DATA);

endif

I don't know how the WS2812 library works but taking into account I'm using leds from the same reel... it seems strange.... Anyway.... SOLVED.

Regarding red color issue I will try replacing the led because I unsolder it from the strip and maybe It's damaged.

Thanks again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Protonerd/FX-SaberOS/issues/76#issuecomment-414008216, or mute the thread https://github.com/notifications/unsubscribe-auth/ATdCMJBds1C9o17OcNgTRMEfgJ-qdeTrks5uR0sigaJpZM4WCOHu .

[AirmakZ]

@jbkuma, one question. Modification has been added in master branch, but seems it's not including all pixel accent features same as beta, right? Is there a merge activity scheduled in the future?

By the way, just confirm that red color issue has been solved replacing the led 👍

[jbkuma]

Until the past couple small fixes I think the master branch matched the beta. Master should be considered the most up to date at the moment.

Jason "Kuma" Brinkerhoff Mad Science Workshoppe, proprietor http://jbkuma.com/workshoppe

On Sat, Aug 18, 2018 at 8:11 AM AirmakZ notifications@github.com wrote:

@jbkuma https://github.com/jbkuma, one question. Modification has been added in master branch, but seems it's not including all pixel accent features same as beta, right? Is there a merge activity scheduled in the future?

By the way, just confirm that red color issue has been solved replacing the led 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Protonerd/FX-SaberOS/issues/76#issuecomment-414053783, or mute the thread https://github.com/notifications/unsubscribe-auth/ATdCMBAMvEbiEKz3FnB0wNAo2mUrP2O6ks5uSAR9gaJpZM4WCOHu .

[AirmakZ]

Understood !! 👍