Closed william-ferguson-au closed 10 years ago
So I found a version of com.android.support:supoprt-v4:19.1.0
that contains NoSaveStateFrameLayout$NoSaveStateFrameLayoutCreator
in the HoloEverywhere repo.
But that begs a couple of questions:
@william-ferguson-au
support-library
branch with name holoeverywhere.patch
But that means I can have a build with this as a dependency:
<dependency>
<groupId>com.android.support</groupId>
<artifactId>support-v4</artifactId>
<version>19.1.0</version>
</dependency>
and it will use 2 totally different artifacts depending on whose machine it is built on.
HE has no right to be publishing artifacts in the com.android.support
group. That is the prerogative of the owner of the android project.
It would be like me publishing org.holoeverywhere:library:2.1.0
with my own versions of the HE classes.
If you really feel like you need to publish your own versions of the support libraries publish them as
org.holoeverywhere.android.support
or similar.
@william-ferguson-au And has conflicts with all other libraries which uses support-library after it. You could build anything with any other patches from any version of code and push it to your own repository or even local repo. I will not publish any other versions of any components into HE's repo.
Btw you could specify version as 19.+
and has always fresh version of library.
Sorry Sergey, I didn't follow any of that.
@Prototik this seems like a huge mistake. If HoloEverywhere is using a modified version of the support library, then publish it under a different name. If HoloEverywhere is using a non-modified but renamed version of the support library to reduce downstream conflicts, that is unnecessary and creating more problems than it solves. Anyone down stream that wants to use a newer version of the support library can exclude that artifact. It is standard practice in the community, these are just two examples plucked out of my build.gradle file.
compile('de.keyboardsurfer.android.widget:crouton:1.8.5') {
exclude group: 'com.google.android', module: 'support-v4'
}
or
androidTestCompile('com.jakewharton.espresso:espresso:1.1-r3') {
exclude group: 'com.google.guava'
exclude group: 'com.google.code.findbugs'
}
@rkistner No many releases of HoloEverywhere ever. You could be your own version with any dependencies - license allow it ;)
It appears that is looking for
android/support/v4/app/NoSaveStateFrameLayout$NoSaveStateFrameLayoutCreator
which doesn't exist anywhere in the android support libraries shipped with the Android SDK.Full log is:
Dependencies are: