search

Provable-Games / loot-survivor

A fully onchain arcade dungeon crawler built on Starknet in conjunction with Realms.world. Explore the dynamically generated dungeons while you fight for your life against beasts and obstacles in pursuit of a spot on the esteemed leaderboard.
https://survivor.realms.world
MIT License
5 stars 7 forks source link

adds view funcs and parameterized launch tourny configs #237

Closed loothero closed 1 month ago

loothero commented 1 month ago

Summary by CodeRabbit

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
loot-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 8:37pm
coderabbitai[bot] commented 1 month ago

Walkthrough

The changes introduce modifications to constants, interfaces, and functions across multiple files in the game codebase. Key updates include a reduction in the obituary expiry duration, the addition of new reward constants, and enhancements to the game interface with new methods for managing promotions and tournaments. The deployment script has also been updated to reflect these changes, particularly in how tournament parameters are configured.

Changes

Files Change Summary
contracts/game/src/game/constants.cairo Updated OBITUARY_EXPIRY_DAYS from 10 to 1; added DAO_CONTRACT_REWARD_ADVENTURER and PG_CONTRACT_REWARD_ADVENTURER.
contracts/game/src/game/interfaces.cairo Added four new methods to the IGame trait for managing promotions and tournaments.
contracts/game/src/lib.cairo Introduced new constants and updated function signatures for tournament management; added functions for genesis adventurers.
contracts/game/src/tests/test_game.cairo Added OBITUARY_EXPIRY_DAYS constant; updated adventurer ID handling and deployment parameters.
scripts/deploy.sh Replaced launch_promotion_end_timestamp with launch_tournament_duration_seconds; added new variables for tournament configuration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GameContract
    participant TournamentManager

    User->>GameContract: Start Game
    GameContract->>TournamentManager: Initialize Tournament Parameters
    TournamentManager->>GameContract: Set Duration and Delay
    GameContract->>User: Game Started with Promotions

Assessment against linked issues

Objective Addressed Explanation
Add view function for free_vrf_promotion_active (233) ✅
Add a launch tournament delay parameter to constructor (228) ✅
Adventurer ID 1 Promotion (129) ❌ No specific implementation for Adventurer ID 1.
Mint Adventurer 2 and 3 to PG and Biblio for contract rewards (224) ❌ No changes related to minting Adventurer IDs 2 and 3.

🐇 Hopping through the code, oh what a sight,
New constants and functions, all shiny and bright!
With tournaments ready and rewards in store,
Adventures await, who could ask for more?
Let's celebrate changes, both big and small,
In the land of the game, we’ll have a ball! 🎉

[!TIP] We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.