Consider name of ROM ONLY for Custom Named ROM ONLY on non-matched/checksum failed ROMs (such as hacks, and translations) ONLY when Electing for Singular ROM Cover Art Download Request

[orenwolf]

Hey guys,

Thanks for all your hard work. I wish I had the iOS dev skillset to help on development, but unfortunately, all I can do is help test, report bugs, and suggest enhancements. To that end:

While I know cover art renaming is coming for tvOS, I was wondering if performing another search on rename was possible? In a lot of cases where the ROM checksum doesn't match, and the name is wrong, we end up cover-art-less. If a rename would allow for a search to succeed, then perhaps that's a simple feature addition that might make it possible for us to look up the box art ourselves and rename the ROM to match?

Thanks!

[sevdestruct]

@orenwolf: ok but what if i rename a file that i have custom art on (often the case with translated roms, especially as they don't match checksums and are common candidate for custom art, considering)?

I think the better way to go would be to consider the custom rename when a user manually requests a cover art to download on a specific rom, rather than every time a file is renamed..

[JoeMatt]

This is kind of moot, the search isn't based on the display name, it's based on the filename. When you rename a game in Provenance it only renames the 'title' entry in the database, the filename is the same as it is on import.

[sevdestruct]

I agree, @joe., Only reason for this would be... (updating name of Issue) There. haha.

[JoeMatt]

This would be pretty easy to add, just add additional fallback searches to the part where we search for filename.

But the question is, what if multiple ROMs match by the display title? You want to set them all?

[sevdestruct]

I think we should only do this when you long press on a single game, otherwise people are going to lose custom game art (that is unless/until #730 is implemented)

[JoeMatt]

I think I understand what this ticket is asking now,

1. A rom is imported correctly into a system but,
2. It didn't match the OpenPV database therefore,
3. The box art is the default blank.

You want,

1. Rename the 'title' field of the rom,
2. if it wasn't previously matched, meaning the PVGame.originalArtworkURL.isEmpty,
3. Search the database again for that system the game is already in , but by the new 'title' field.
4. If match found, update the metadata and images for the PVGame entry

I suppose this is moderately easy to do.

[sevdestruct]

Bingo.