ProvideQ / toolbox-server

Resources for the server that hosts the toolbox (Backend)
https://provideq.kit.edu
MIT License
1 stars 1 forks source link

Docker Deployment #11

Closed schweikart closed 1 year ago

Elscrux commented 1 year ago

The changes to maxcut.lst, qiskit.py and QiskitMaxCutSolver.java will be updated in #12 which streamlines external handling of solver files. The rest of of docker deployment might not be affected by this. However you seem to copy gams and qiskit folders explicitly. In #12 those folders will be moved to the resources folder. This might need to be adjusted here as well.

schweikart commented 1 year ago

The changes to maxcut.lst, qiskit.py and QiskitMaxCutSolver.java will be updated in #12 which streamlines external handling of solver files. The rest of of docker deployment might not be affected by this. However you seem to copy gams and qiskit folders explicitly. In #12 those folders will be moved to the resources folder. This might need to be adjusted here as well.

I don't think Python or GAMS can read files from within JARs, so it's kind of unnecessary to package the scripts with the JAR file. I could just copy the src/main/resources folder to the docker container but that seems kind of unnecessary. Is #12 urgent or can it wait until we had the time to discuss this?