search

ProvidenceGeeks / website-frontend

UI frontend repository for the Providence Geeks website
https://www.pvdgeeks.org
7 stars 9 forks source link

Share Social Media links do not open Native Apps on mobile devices #126

Open saimatsumoto opened 6 years ago

saimatsumoto commented 6 years ago

Type of Change

Summary

  1. Clicking on share social icons in events-list, blog-posts, and blog-details page on mobile devices do not open native app.
  2. OS/Browser: Galaxy S5 / Chrome v53.0.2785.124 iPhone5c / Safari v10.0
  3. Environment: https://stage.pvdgeeks.org
  4. Exact steps to reproduce
    1. Go to https://stage.pvdgeeks.org
    2. On Events-List, click on the share facebook or twitter icon of one of the events
    3. Click on "Blog Posts" tab, click on the share facebook or twitter icon of one of the blogs
    4. Click on a blog from a post list, click on the share facebook or twitter icon in the blog details page.
  5. Expected result: clicking on share icon will open the links in the mobile's native app (Facebook/Twitter/LinkedIn) if app is on the device.
  6. Actual result: Opens the link in new tab regardless of if the device has facebook/twitter native app or not.
thescientist13 commented 6 years ago

I think this makes a strong case for being able to create a more reusable ShareBar component (as was made in #57 when creating the Blog Posts Details page), since we now have this behavior and expectations spread out across multiple places

  1. Header
  2. Footer
  3. Events / Blog Posts List
  4. Blog Post Details Page

We may want to capture this officially as a component in the Application Design and make a ticket for this.

saimatsumoto commented 6 years ago

https://github.com/ProvidenceGeeks/website-docs/issues/39