Closed thescientist13 closed 6 years ago
So after rebasing to pull in the webpack v4 upgrade work, I am seeing some very interesting results.
Compared to the local results observed in the webpack v4 upgrade PR, it looks like although the I am now seeing an increase of about 6 assets / chunks worth of (JS / CSS)
BUT!!!! The app scored a 74 in performance locally!!!! 😮
So given the payload size stayed the same, my guess is that webpack is doing its best to strategically chunk based on best practices like keeping chunks small, but still leveraging the browser's ability to download and parse in parallel (i.e. what HTTP/2 is meant to promote).
Should work on trying to look into that CSS but this seems to be a game changer of a PR 🏅
Fixed the CSS issue thanks to this comment which now gives a local score of 75!!! 🎉
just now seeing this issue though when trying to load the post details route though
Uncaught SyntaxError: Unexpected token <
index.220f8a217c2b04194a5a.bundle.js:1 Uncaught (in promise) Error: Dynamic page loading failed: Error: Loading chunk 4 failed.
(missing: http://127.0.0.1:8080/post/4.chunk.js)
at c (index.220f8a217c2b04194a5a.bundle.js:1)
The URL the browser is trying to load, http://127.0.0.1:8080/post/4.chunk.js seems suspect. 🤔
Related Issue
resolves #137
Summary of Changes
import()
to lazy load Post Details page<base href="/">
to ensure proper loading of dynamic chunks within nested routesSome concerns around performance as per comments in the issue