search

ProvidenceGeeks / website-frontend

UI frontend repository for the Providence Geeks website
https://www.pvdgeeks.org
7 stars 9 forks source link

Technical/issue 165 remove moment #166

Closed thescientist13 closed 6 years ago

thescientist13 commented 6 years ago

Related Issue

resolves #165

Summary of Changes

  1. Created a DateFormatterService with static methods for formatting Blog Post and Event timestamps
  2. Removed dependency on moment

TODO

  1. [x] Add timezone support back in (will fix breaking build)
  2. [x] Capture benchmarks, BundleAnalyzer, etc
thescientist13 commented 6 years ago

@DevLab2425 Looking good now I think

Before

moment-before-network-requests moment-before-bundle-analyzer

After

moment-after-network-requests moment-after-bundle-analyzer

Stats

  1. 1 less HTTP request
  2. 242KB saved 😮
  3. Bundle total down .45MB!

All signs seem to point to 🚀

Will run Lighthouse reports on stage after this is merged, but this definitely seems like a good improvement either way, but hopefully bumps up our Performance score a little! ⚡️