Event Description Cleanup

caleboller commented 5 years ago

Related Issue

There's no existing documented issue.

Summary of Changes

This PR does two things to clean up the appearance of Event description blurbs in Cards in a CardList.

The event body can contain raw html. This PR renders the event body such that the raw html is rendered appropriately.
Removes the 160 character max for the event body. This behavior was chopping words. Instead, it uses a line clamping technique to render only three lines and fades out the third line.

Before

After

caleboller commented 5 years ago

Oops - I should get tests passing. 😱

thescientist13 commented 5 years ago

Thanks @caleboller for the PR! 😄

i like the changes you are proposing, but generally we do appreciate having an issue made ahead of time, just so appropriate context and proposals can be discussed outside of the code review process itself.

I think if we could get an issue opened for this, I would like to discuss this couple point a bit more:

Maybe we could use ellipsis instead of fading out text? I guess since it's just trailing text it's not a huge deal, but fading out text might impact readability.
Is there another option for rendering HTML instead of pulling in a library?

Thanks and let me know your thoughts.

DevLab2425 commented 4 years ago

Closing due to lack of corresponding issue, failing test(s) and file conflict. Feel free to reopen when the corrections have been made.

ProvidenceGeeks / website-frontend