Open DevLab2425 opened 5 years ago
New Feature Request / Improvement:
Description: There are two components that share some similar HTML. The following two Facebook links are duplicated in two components. This is repeated with the Twitter buttons as well.
// card.jsx <a className="facebook-share" href={ `https://www.facebook.com/sharer/sharer.php?u=${ encodeURIComponent(this.props.facebookShareMessage) }` } target="_blank" rel="noopener noreferrer" aria-label="Like PVDGeeks on Facebook" > <FacebookIcon /> </a>
// social-follow-links.jsx <a className="facebook-link" href="https://www.facebook.com/providencegeeks/" title="Like Us" target="_blank" rel="noopener noreferrer" aria-label="Like PVDGeeks on Facebook" > <FacebookIcon /> </a>
I propose a consolidated component along the lines of
<FacebookLink type="'profile' || 'share'" url="http://www.url/to/share" /> // and <TwitterLink type="'profile' || 'share'" url="http://www.url/to/share" />
Type of Change
Summary
New Feature Request / Improvement:
Description: There are two components that share some similar HTML. The following two Facebook links are duplicated in two components. This is repeated with the Twitter buttons as well.
I propose a consolidated component along the lines of