search

Provismet / Additional-Armoury

Adds weapons, magic, and more materials.
https://provismet.github.io/modding?tag=null&series=Combat%2B
Other
2 stars 0 forks source link

1.21 Missing Translations #6

Closed makumaku1974 closed 2 months ago

makumaku1974 commented 2 months ago

Type of Error

Other

Description

Missing Translations

Mod Version

2.0.0

Minecraft Version

1.21

Mod Loader

Fabric

Steps to Reproduce

image

Crash Log

No response

Provismet commented 2 months ago

Scorching? I've never heard of this potion effect, is it from another mod?

makumaku1974 commented 2 months ago

Ohhh it's from Wilder Wilds which is a great mod. Should i report this to them too?

This is from Contagion image

This is from Stamina Tweakers image image

Provismet commented 2 months ago

That's the reason for the missing translation. Translation keys are not automatic, each one must be manually added.
In other words, although daggers are compatible with modded potions, unless someone manually adds a translation for it, it will just show the key.

This isn't a bug on either side. My advice would be to create your own resourcepack for your modpack with the translation keys added.
You could also try sending this report to the other mod developers in hopes that they'll add keys for you, but understand that most probably aren't too interested in adding dozens of translation keys for this.

makumaku1974 commented 2 months ago

okay okay got it. Is there a way for you to tell me what I should do when customizing it using resourcepacks? I'm quite a newbie when it comes to coding it let alone figuring out translation errors.

Provismet commented 2 months ago

Sure, resourcepacks are honestly very simple though. They aren't code at all. You just need to create a a lang file to provide translation keys.

  1. Create a new folder (this folder will be the resoucepack itself).
  2. Add a pack.mcmeta file to your folder. You can check the wiki for the for the format (or just copy one from an existing resourcepack and change the name/description).
  3. Add a new path of folders: assets -> name_of_your_pack -> lang a. The name doesn't matter as long as it's all lowercase with no spaces.
  4. Inside lang make a new file en_us.json (or whatever language you want, en_gb would be the far superior British English, for example)
  5. Add your translation key, format looks like this.
makumaku1974 commented 2 months ago

It kinda looks tiring to look at but holy still going to do it though.

NathanX-S commented 1 week ago

@Provismet Wouldn't it make more sense to automatically create these names using a "base name" from your mod and then concating the name of the effect from the other mod/base game?

Provismet commented 1 week ago

No, that's not how this works.

Translation keys are converted into names via a resourcepack; I can and do automatically generate names in English; this does not happen in real-time and is only used to generate the built-in resourcepack. I cannot do this for modded potions, it is up to modpack makers or other modders to add those additional keys.