Provismet / Provi-Origins

Provi's custom Origins.
https://modrinth.com/mod/provis-origins
Other
2 stars 0 forks source link

`proviorigins:emissive` Does not work with LambsDynamicLights #9

Closed Lunaticol closed 2 months ago

Lunaticol commented 3 months ago

Type of Error

Incorrect Behaviour

Description

I have a power which uses proviorigins:emissive and has a specific light level set, but lambsdynamiclights doesnt seem to pick up on this. image image

Mod Version

1.5.2

Minecraft Version

1.20.1

Mod Loader

Fabric

Steps to Reproduce

1. Create emissive power
2. see error

Crash Log

No response

Provismet commented 3 months ago

Can you confirm what version of LambDynamicLights you're using? I will investigate this when I get a chance.

Lunaticol commented 3 months ago

2.3.2

Provismet commented 2 months ago

I've looked into this a little further and the cause is because you're missing a parameter in your power.

The light field only determines the strength of the emissive lighting, not the dynamic lighting.
You need to add a dynamic_light field if you want to have dynamic lighting. Check the Splinter's glow for reference.

Lunaticol commented 2 months ago

alright ill go see if that works

Lunaticol commented 2 months ago

seems to of worked, Thanks! image