Provismet / ProviHealth

Adds sleek and expansive healthbars to Minecraft.
https://modrinth.com/mod/provis-health-bars
Other
3 stars 1 forks source link

Love the mod! #1

Closed LastRaidBoss closed 9 months ago

LastRaidBoss commented 9 months ago

Everything works great but would it be possible to add options to make the colors different like dark mode instead of light mode for example would be perfect. Also if color hues based on % of damage dealt like at 75% it turns slightly yellowish then 50% it's orange then 25% it starts turning bright red or something like that would be super dope not sure how easy that would be to add.

thanks!

Provismet commented 9 months ago
  1. I'm not sure what you mean by light and dark mode in this context. If you could send an illustration that would be great. Though if you mean to simply have darker textures you can already achieve this via a resource pack.

  2. Colour-changing bars are theoretically possible. Though I would need to look into it and grayscale out the current bar textures.

LastRaidBoss commented 9 months ago
  1. I'm not sure what you mean by light and dark mode in this context. If you could send an illustration that would be great. Though if you mean to simply have darker textures you can already achieve this via a resource pack. ok
  2. Colour-changing bars are theoretically possible. Though I would need to look into it and grayscale out the current bar textures. It would be cool for rpg servers where you kill packs of monsters seeing where you need to do dmg to lower hp ones just by looking at the colors yeah. but either way it's a great mod no issues or bugs super clean.

Question... Is there anyway to show the health bars for mobs with invisibility tag for RPG servers who use invisible mob tags as a gimmick to add new mobs in vanilla? It sucks not seeing health of custom mobs due to them being normal minecraft mobs with invis potion tag also making the health invisible even though the actual new mob created by the server isn't.

LastRaidBoss commented 9 months ago
  1. I'm not sure what you mean by light and dark mode in this context. If you could send an illustration that would be great. Though if you mean to simply have darker textures you can already achieve this via a resource pack. ok
  2. Colour-changing bars are theoretically possible. Though I would need to look into it and grayscale out the current bar textures. It would be cool for rpg servers where you kill packs of monsters seeing where you need to do dmg to lower hp ones just by looking at the colors yeah. but either way it's a great mod no issues or bugs super clean.

Question... Is there anyway to show the health bars for mobs with invisibility tag for RPG servers who use invisible mob tags as a gimmick to add new mobs in vanilla? It sucks not seeing health of custom mobs due to them being normal minecraft mobs with invis potion tag also making the health invisible even though the actual new mob created by the server isn't.

Plus damage indicators like something similiar to toro health has would be sweet I love the UI from this compared to toro tho but seeing dmg dealt is super nice for rpg servers/modpacks.

Provismet commented 9 months ago

Question... Is there anyway to show the health bars for mobs with invisibility tag for RPG servers who use invisible mob tags as a gimmick to add new mobs in vanilla? It sucks not seeing health of custom mobs due to them being normal minecraft mobs with invis potion tag also making the health invisible even though the actual new mob created by the server isn't.

The decision to not render invisible mobs with health bars was intentional (the mod actually checks if the mob is invisible). It's to prevent the mod from being equivalent to cheating (seeing invisible players, illusioners, etc).
I am able to disable this, but I don't have a viable method to distinguish a normal invisible mob from custom ones.

I also play RPG-like servers, so I have some ideas for partially resolving this. But if you could tell me more about the specifics, I can potentially add an exception (such as rendering health bars for invisible mobs that still have armour on).

Plus damage indicators like something similiar to toro health has would be sweet I love the UI from this compared to toro tho but seeing dmg dealt is super nice for rpg servers/modpacks.

I am planning to add this feature eventually, I just need to find a good way to implement it. I am also soon adding armour points to the HUD.

LastRaidBoss commented 9 months ago

Here is an example for a mob that is like a ghostly set of armor javaw_tLoWYZXlXn

LastRaidBoss commented 9 months ago

Here is an example for a mob that is like a ghostly set of armor javaw_tLoWYZXlXn

I'm not exactly sure what they did to create the custom mob all I know is it uses invisible tag so you don't see the base mob because that would make it look stupid. I know that for a fact because I've spoken directly to the devs and they confirmed it's because they have invisible tags which break some health mods. Toro Health does have a way to fix it inside the settings but it only works for hud not inworld bars for some reason.

Provismet commented 9 months ago

It looks to me like it's an invisible mob wearing armour and a Player Head.
I've added a fix that will render the health bar for invisible mobs if one of the following conditions is met:

Here's an example. image

This patch will be live in the next update alongside viewing armour points and hopefully damage particles.

LastRaidBoss commented 9 months ago

It looks to me like it's an invisible mob wearing armour and a Player Head. I've added a fix that will render the health bar for invisible mobs if one of the following conditions is met:

  • Is wearing an item on its head.
  • Is wearing an item on its chest.
  • Has a rider (such as "DisplayEntities" which are sometimes used by plugins and datapacks).

Here's an example. image

This patch will be live in the next update alongside viewing armour points and hopefully damage particles.

Fucking awesome!

LastRaidBoss commented 9 months ago

It looks to me like it's an invisible mob wearing armour and a Player Head. I've added a fix that will render the health bar for invisible mobs if one of the following conditions is met:

  • Is wearing an item on its head.
  • Is wearing an item on its chest.
  • Has a rider (such as "DisplayEntities" which are sometimes used by plugins and datapacks).

Here's an example. image

This patch will be live in the next update alongside viewing armour points and hopefully damage particles.

javaw_d9Tt46dI0u

Everything works great all the monsters have healthbars besides one mobtype which is slimes for some reason?

LastRaidBoss commented 9 months ago

It looks to me like it's an invisible mob wearing armour and a Player Head. I've added a fix that will render the health bar for invisible mobs if one of the following conditions is met:

  • Is wearing an item on its head.
  • Is wearing an item on its chest.
  • Has a rider (such as "DisplayEntities" which are sometimes used by plugins and datapacks).

Here's an example. image This patch will be live in the next update alongside viewing armour points and hopefully damage particles.

javaw_d9Tt46dI0u

Everything works great all the monsters have healthbars besides one mobtype which is slimes for some reason?

oh and I mean the ingame healthbar the hud works but the actual health bar doesn't and yes I made sure I smacked it and damaged it too and it doesn't pop up still

Provismet commented 9 months ago

Is that Monumenta? The PORTAL strike? I can try and investigate why those slimes are different.

I have a couple guesses, and should be able to fix this soon if my guess is correct.

Provismet commented 9 months ago

In-world health bars don't render for mobs that have living passengers, so my guess is that this type of slime has an invisible armour stand riding it.
(Armour Stands are classified as "living".)

I've already solved this armour stand problem in a developmental build.
So if you can point me to where this slime spawns, I can test it ingame.

LastRaidBoss commented 9 months ago

In-world health bars don't render for mobs that have living passengers, so my guess is that this type of slime has an invisible armour stand riding it. (Armour Stands are classified as "living".)

I've already solved this armour stand problem in a developmental build. So if you can point me to where this slime spawns, I can test it ingame.

wait do you know what server this is lol?

IP: server.playmonumenta.com

It's a common slime inside of P.O.R.T.A.L Strike in Region 3

Provismet commented 9 months ago

wait do you know what server this is lol?

Yeah I love Monumenta, I'm also the person who made the modpack with the custom main menu (will be updating it to 1.20.1 after I finish making some new art assets to integrate Monumenta's custom entity groups into the HUD portraits).

I'll head into PORTAL later today and see if the new changes work there.

Provismet commented 9 months ago

Looks like it was an armour stand issue after all. 2023-12-11_22 54 34

This is now fixed as of mod version 1.2.0, which will be uploaded shortly.

LastRaidBoss commented 8 months ago

Looks like it was an armour stand issue after all. 2023-12-11_22 54 34

This is now fixed as of mod version 1.2.0, which will be uploaded shortly.

Awesome this is becoming one of the best health mods I've used. Sadly the new greyscale health bars don't work with most shaders can you add an option to switch the type of health bar rendering for ppl who only play with shaders on? Thanks

Provismet commented 8 months ago

It's definitely on my to-do list. Were the bars rendering properly before the colour changing feature was added?

LastRaidBoss commented 8 months ago

It's definitely on my to-do list. Were the bars rendering properly before the colour changing feature was added?

yes I had to downgrade back to the 2nd release instead because I've used these shaders for so long I can't stand vanilla haha

Provismet commented 8 months ago

Thanks for the info, 1.2.1 is now on Modrinth. Note though that the compatibility mode for health bars will disable the colour changing feature (colour changing requires a Render Program that some shaders will break).

LastRaidBoss commented 8 months ago

Thanks for the info, 1.2.1 is now on Modrinth. Note though that the compatibility mode for health bars will disable the colour changing feature (colour changing requires a Render Program that some shaders will break).

that's fine, that's like the only feature I could go without anyways looks great!