Provismet / ProviHealth

Adds sleek and expansive healthbars to Minecraft.
https://modrinth.com/mod/provis-health-bars
Other
3 stars 1 forks source link

Hello #4

Closed OneWorldStudio closed 9 months ago

OneWorldStudio commented 9 months ago

Hello, can you make the mod work for you with the MythicMobs and ModelEngine plugin?

OneWorldStudio commented 9 months ago

https://modrinth.com/mod/provis-health-bars/gallery

Provismet commented 9 months ago

I am unable to add direct support for anything outside of the Fabric ecosystem, plugins are fully server-side and are not mods. The mobs they add are not "real" and are functionally illusions. It's not possible for the mod to detect them. However, if the plugin mobs are built on-top of an existing mob, then this might be possible.

Could you please give me an example of the issue? If you could describe the mobs that don't work (preferably with a screenshot or short video of the mod not working on them) then I can see if it's something I can solve.

Also please confirm which version of the mod you're using. A similar issue was solved in version 1.1.0 of the mod.

OneWorldStudio commented 9 months ago

voras: Type: IRON_GOLEM Display: 'Voras' Health: 500 Modules: ThreatTable: true AIGoalSelectors:

Screenshot_46 Screenshot_47 Screenshot_45

Mod Last Vervion

I think it's possible to do this, even the Legendary ToolTip mod animates any item with a custom texture from ItemsAdder and any other texture from pack textures.

Provismet commented 9 months ago

So if I'm understanding this correctly this mob is an invisible Iron Golem with DisplayEntities moving around it?
If so, then are the DisplayEntities being moved by the server plugin? Are any of them passengers of the Iron Golem?

OneWorldStudio commented 9 months ago

Yes, it's DisplayEntities, when I add a model, the vanilla mob hides behind the model. Yes, there's a vanilla mob sitting in it, with a model already on it.

OneWorldStudio commented 9 months ago

All mobs on which there are DisplayEntities, move due to the plugin in which the engine is developed for this.

Provismet commented 9 months ago

I can make an experimental build that considers a mob "visible" if it is touching a DisplayEntity.

OneWorldStudio commented 9 months ago

I would be very grateful and would love to test this out. Could you also make it so that you can move the indicator. For example, to the center or to the upper right corner. Exactly which one is on the screen.

OneWorldStudio commented 9 months ago

Screenshot_49 Screenshot_48

Provismet commented 9 months ago

I would be very grateful and would love to test this out.

There is now a branch for this fix. Github won't let me send JAR files in comments, so instead you can find the auto-built JAR in the build status. It will download an Artifacts.zip containing the mod JAR and source.

Could you also make it so that you can move the indicator. For example, to the center or to the upper right corner. Exactly which one is on the screen.

This is possible and I plan to add this feature, but it's not something I can implement quickly. The assets I drew are designed for the left-side and aren't symmetrical.
To my knowledge Minecraft doesn't support simply flipping the textures, which means that all the health bar HUD textures would need to be manually duplicated and I would have to create a new registry system to accomodate this.

OneWorldStudio commented 9 months ago

1.1.1 did not display a custom mob

Provismet commented 9 months ago

Strange, I set the search radius to 5 blocks, which I assumed would be large enough for this purpose. I can confirm an invisible zombie standing next to a BlockDisplayEntity had visibile health bars.

I've pushed another commit. This one has a configurable search size in the config menu (incase the space between the Iron Golem and the DisplayEntities is larger than I thought).

Could you also enable hitboxes, set the Iron Golem to glow and take a screenshot of the custom mob please?

OneWorldStudio commented 9 months ago

Screenshot_51 I do not know how to make it shine

Provismet commented 9 months ago

I do not know how to make it shine

use /effect give @e[type=minecraft:iron_golem] glowing to grant glow to all Iron Golems for a short duration.

Do health bars (HUD or overhead) fail to show for all custom mobs? Or do some work? I have a suspicion that the health bar for the Voras monster might be rendering correctly but is hidden inside the custom mob due to its size.
The health bars in the world can have their sizes scaled, does it become visible when at the maximum size?

OneWorldStudio commented 9 months ago

The glow does not occur Screenshot_53

OneWorldStudio commented 9 months ago

It doesn't show anything on custom monsters

Provismet commented 9 months ago

I'll look further into this tomorrow. For now could you please confirm your settings.

OneWorldStudio commented 9 months ago

I have tried all the settings, but the progress there is a plugin ItemsAdder catches these objects, although I would no Screenshot_54 Screenshot_39 t really like it to be so.

Provismet commented 9 months ago

Sorry that this is going back and forth so much, but that's simply the nature of trying to get a client-side mod to interact in any way with a server-side plugin when neither knows of the other. It just requires a lot of troubleshooting.

I've push a new experimental commit. This build completely removes the visibility check from mobs. Please test it with your custom mobs (ensuring that in your settings the in-world health bars for all mobs are set to "Show").

If this works I can fine-tune it over time, but if this does not work then it would seem the compatibility is not possible.

OneWorldStudio commented 9 months ago

Eh, it doesn't work

Provismet commented 9 months ago

In that case it seems that it's simply not possible to make the mod compatible with modelengine mobs.
Thank you for helping me investigate this, however.

OneWorldStudio commented 9 months ago

В таком случае кажется, что сделать мод совместимым с мобами modelengine просто невозможно. Однако спасибо, что помогли мне расследовать это.

okay, thanks