Provismet / Tooltip-Scroll-Fabric

Simple client-side Minecraft mod that allows tooltips to be moved with the scrollwheel or keybinds.
MIT License
4 stars 8 forks source link

Incompatibility with ToolTipFix #21

Open poqli opened 3 months ago

poqli commented 3 months ago

Type of Error

Incorrect Behaviour

Mod List

mc1.20.1 w/ Fabric

Description

Expected behavior: Tooltip of the hovered item is moved horizontally when scrolling and either holding left-shift or the custom keybind. Actual behavior: Tooltip does not move.

Horizontal scrolling doesn't seem to work when this mod is used with ToolTipFix. This was tested with the "Use Left-Shift" setting and the custom keybind. This also applies to WASD controls, where A and D do not move the hovered tooltip.

Mod Version

tooltip-scroll-1.3.0, tooltipfix-1.1.1-1.20

Minecraft Version

1.19.4 (Latest)

Mod Loader

Fabric

Steps to Reproduce

- Run mc1.20.1 with Fabric and Tooltip Scroll, ToolTipFix, Cloth Config, Mod Menu, Fabric API.
- Load any world or server.
- Ensure that "Use Left-Shift" is enabled.
- Obtain any item and open the inventory.
- Hover over the item, hold Left-shift, and scroll.

- For WASD, enable "Enable WASD" for Tooltip Scroll and press A or D when hovering over an item.

Crash Log

No response

Provismet commented 3 months ago

This is known issue, between the two mods.

This occurs due to how mods are loaded, both Tooltip Scroll (horizontal scrolling) and ToolTipFix (moving the tooltip to the side) work by modifying the exact same parameter. This makes the two mods incompatible.

Technically this can be fixed, but only from ToolTipFix's side. Tooltip Scroll intentionally provides a convenient injection point in ScrollTracker.java for this exact reason.