ProwlEngine / Prowl

An Open Source C# 3D Game Engine under MIT license, inspired by Unity and featuring a complete editor and built on Silk.NET
MIT License
328 stars 27 forks source link

File creation fixed (Issue #103) #104

Closed Kuvrot closed 5 months ago

Kuvrot commented 5 months ago

Fix to the problem where the files were being created only at the root folder instead of the desired one (Issue #103 )

https://github.com/michaelsakharov/Prowl/assets/23508114/8ba3b94d-ce69-4880-802a-e70ce10895cd

I made the CurDirectory variable from the AssetBrowserWindow.cs static in order to indicate the path where the file will be created in MainMenuItems.cs

michaelsakharov commented 5 months ago

Pushed a possible fix to this just now, Let me know if it works for you.

Kuvrot commented 5 months ago

It didn't work for me.

michaelsakharov commented 5 months ago

Dang, Can you show a clip of how exactly your creating the files?

michaelsakharov commented 5 months ago

Sorry i missed a compile error

Kuvrot commented 5 months ago

It also should support when right-clicking a folder and pressing Create Material, it should create it inside the folder not the directory I'm inside.

To be more specific, this is working, right clicking a folder and creating a file, will create the file inside the folder clicked.

What is not working is this:

https://github.com/michaelsakharov/Prowl/assets/23508114/bc0b4880-354c-418c-ad73-236094a462d8

michaelsakharov commented 5 months ago

It also should support when right-clicking a folder and pressing Create Material, it should create it inside the folder not the directory I'm inside.

To be more specific, this is working, right clicking a folder and creating a file, will create the file inside the folder clicked.

What is not working is this:

Prowl2024-03-0217-41-29-ezgif.com-crop-video.mp4

This seems to be working for me on my last commit

Kuvrot commented 5 months ago

Oh really?, let me check it again then.

Kuvrot commented 5 months ago

Ahhhh yes, sorry, you are right, I made a new clone of the repo and it's working.

michaelsakharov commented 5 months ago

Awesome :D