ProxioDev / ValioBungee

Synchronize players data between BungeeCord / Velocity proxies
Eclipse Public License 1.0
191 stars 50 forks source link

Invalidate serversToPlayersCache on player updates #103

Closed md5nake closed 2 months ago

md5nake commented 2 months ago

This closes #102

md5nake commented 2 months ago

I think this is a better approach than removing caching entirely. The less we query Redis, the better

ham1255 commented 2 months ago

thing is even if this cache existed like what i saw in the code, that players frequently change servers which makes cache useless due huge amounts of invalidated stuff

md5nake commented 2 months ago

Even if cache invalidations are frequent, we still invalidate it when an update is made, and in the meantime we might get some cache hits. I think this is the right way to go about it.

ham1255 commented 2 months ago

looks good then, i reverted my commit