search

ProxioDev / ValioBungee

Synchronize players data between BungeeCord / Velocity proxies
Eclipse Public License 1.0
204 stars 52 forks source link

Allow to customize ping events priority via handle-motd-order #108

Closed dasavick closed 3 months ago

dasavick commented 3 months ago

Currently, the bungee implementation is using NORMAL priority for the ping event handler, while the velocity implementation is using LAST. Regardless of which choice may be the better one, this is an inconsistency that this patch addresses by using NORMAL as the default for both platforms.

Additionally to addressing the inconsistency, this patch adds a new config option handle-motd-order which uses velocity's event priority nomenclature to allow configuring the behavior of the MOTD handling on both platforms.

In cases where there is a MOTD plugin that incorrectly overrides a player count using the local player count, one may choose to use order LAST to override the value back to the global player count.

In cases where there is a MOTD plugin that relies on a player count value from the ping response, one may choose to use order FIRST to make sure the response will have the correct global player count.

Fixes https://github.com/ProxioDev/ValioBungee/issues/107

ham1255 commented 3 months ago

Looks good

ham1255 commented 3 months ago

Currently, the bungee implementation is using NORMAL priority for the ping event handler, while the velocity implementation is using LAST. Regardless of which choice may be the better one, this is an inconsistency that this patch addresses by using NORMAL as the default for both platforms.

i think this happened when i have split internals to support proxies other than bungeecord

Ayouuuu commented 2 months ago

private method should be public

ham1255 commented 2 months ago

yeah it was screw up on my part for not checking bungeecord impl correctly. i didn't