search

ProxioDev / ValioBungee

Synchronize players data between BungeeCord / Velocity proxies
Eclipse Public License 1.0
200 stars 51 forks source link

Backward compatability #28

Closed Simonsator closed 2 years ago

Simonsator commented 2 years ago

Not anymore relocating the Jedis to com.imaginarycode.minecraft.redisbungee.internal.jedis breaks all plugins using the Jedis from Redis.

ham1255 commented 2 years ago

Hmmm in that case i should revert it, but problem is if plugin would import redisbungee from maven repository (not the jar itself) it will use normal jedis packages naming which also causes error, as i would add relocating to my plugin if it used redisbubgee too

Simonsator commented 2 years ago

If it is importing the compiled version of redisbungee using maven it does use the correct package. And I am not aware of any importing solution where it would use the wrong package.

ham1255 commented 2 years ago

Current problem is that maven project does not know that redisbungee has relocated classes if imported from repository, it kept throwing NoSuchMethod till i removed the relocation, since i mentioned that in the release notes

ham1255 commented 2 years ago

I might stop shading Jedis and use bungeecord automatic lib loading that was introduced in 1.16

Simonsator commented 2 years ago

I am importing it using 

  <dependency>
com.github.limework redisbungee 0.6.5 provided

And it works just fine using com.imaginarycode.minecraft.redisbungee as the package for it.

ham1255 commented 2 years ago

releasing an update shortly