ProxioDev / ValioBungee

Synchronize players data between BungeeCord / Velocity proxies
Eclipse Public License 1.0
200 stars 51 forks source link

RedisBungee placeholders do not work for Velocity version #38

Closed ghost closed 2 years ago

ghost commented 2 years ago

Describe the bug The Placeholder API Placeholders for RedisBungee does not update on Velocity version

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior The Placeholders should refresh

Screenshots If applicable, add screenshots to help explain your problem.

Redis version? it should be at least 6 and above. 6.0.6

Bungeecord version or (the bungee fork name eg: waterfall) and your plugins 3.1.1

console logs? please provide any errors if there any.

ghost commented 2 years ago

Turns out the plugin messages are disabled at velocity for now. My bad I guess. If you guys can just tell me if there is a deadline for it to arrive!

ham1255 commented 2 years ago

no worries,but for some odd reason velocity plugin message is being weird getting random data

that why i disabled it.

ghost commented 2 years ago

Does it block connections of some sort? If not can I just enable it myself embracing the random data part

ham1255 commented 2 years ago

Does it block connections of some sort? If not can I just enable it myself embracing the random data part

no not that, when the proxy gets the message it gets data that does not make sense like its random, might look at it tomorrow or today.

ghost commented 2 years ago

Does it block connections of some sort? If not can I just enable it myself embracing the random data part

no not that, when the proxy gets the message it gets data that does not make sense like its random, might look at it tomorrow or today.

Thank you for the fast response. Take your time with the fix

areuddin commented 2 years ago

Hi,

Any updates on this?

ham1255 commented 2 years ago

Will be pushing a commit in next few hours hopefully i got it right.

areuddin commented 2 years ago

Hi,

Is there another commit to come or is this the latest commit? It doesn't look like what is required, just wanted to check.

ham1255 commented 2 years ago

That was change i pushed by mistake

ham1255 commented 2 years ago

try building that commit ^ and please tell me your results

803ae36d00566505df0384c94b3d7437863cfe7b fixes everything.

ghost commented 2 years ago

We pushed the latest version on live server and the placeholders still show as 0 sadly.

Edit: Well it somehow shows some data on some servers right now but its like the refresh times are all over the place

areuddin commented 2 years ago

I can update that it is not working at all, restarting the server or using /papi reload will set them to 0 again.

ham1255 commented 2 years ago

Yup expansion by default refresh rate is 60 seconds

ham1255 commented 2 years ago

I am reopening this as somebody in spigot messages too reporting getting zeros only

ham1255 commented 2 years ago

https://github.com/ProxioDev/RedisBungee/commit/482dfc51414d3a73fa18f8c76f415a8b5b04e961 referencing this commit that caused plugin messages to use proxy due fact it was named server

ham1255 commented 2 years ago

At the moment plugin message from me at least works for me, not sure why it does not for somebody, cause few months ago somebody reported the same issue on bungeecord, before 0.7 internal change, here test i did testing the plugin messages using expansion with one player on total: image with 2 players: image this 2 players on a lobby server: the command ran 3 times first one is to tell the expansion to request server on the next request second was ran 1 second later would show 0 third time command ran was 1 min later would show 2 players image

this was on velocity

areuddin commented 2 years ago

parse For us the placeholders 'kinda' work, but it's incorrect. At the time of writing this, we have 352 players on, on Lobby 1 it shows 239, so it's showing nearly 100 players less. What doesn't make sense is that we have 3 hub servers, and they all seem to display different %redisbungee_total% counts in the scoreboard.

It's just very mixed, some places still show 0 and they've been up for longer than 60 seconds. I can send the Server IP if you wish so you can see what I mean, let me know.

ham1255 commented 2 years ago

Hmmm, maybe the expansion is at fault here?

ham1255 commented 2 years ago

Reason i said that, motd shows correct number of total players, which exclude problem at redisbungee proxy side @areuddin Could you confirm that?

areuddin commented 2 years ago

Yes, the MOTD is showing the combined player count (we have 2 proxies) - our Minetracker is also showing the correct number

ham1255 commented 2 years ago

Yes, the MOTD is showing the combined player count (we have 2 proxies) - our Minetracker is also showing the correct number

Does it have fluctuations like placeholder one numbers etc? Like how smooth graphs is, also whats interval when getting checked?

ghost commented 2 years ago

Yes, the MOTD is showing the combined player count (we have 2 proxies) - our Minetracker is also showing the correct number

Does it have random drops of numbers etc? Like how smooth graphs is.

Its perfectly smooth, Doesnt drop at all

ghost commented 2 years ago

Yes, the MOTD is showing the combined player count (we have 2 proxies) - our Minetracker is also showing the correct number

Does it have random drops of numbers etc? Like how smooth graphs is.

Its perfectly smooth, Doesnt drop at all

I feel like the issue is the placeholdersi refresh times because of the refresh time itself or caching. idk exact though

ham1255 commented 2 years ago

This repository of the expansion by clip, since i did update it last year https://github.com/PlaceholderAPI/RedisBungee-Expansion/

areuddin commented 2 years ago

Yes, the MOTD is showing the combined player count (we have 2 proxies) - our Minetracker is also showing the correct number

Does it have fluctuations like placeholder one numbers etc? Like how smooth graphs is, also whats interval when getting checked?

https://tracker.gappl.es/

ham1255 commented 2 years ago

https://github.com/PlaceholderAPI/RedisBungee-Expansion/pull/3