Proxlight / Proxlight-Designer-v2

MIT License
123 stars 53 forks source link

It would be nice to add `ttk.Combobox` #14

Closed joao-vitor-souza closed 1 year ago

joao-vitor-souza commented 1 year ago

How hard would it be to implement the conversion of ttk.ComboBox? It works like a dropdown and it's a subclass of Entry, which is already implemented. Are there any plans to add more elements? I could work on this!

Proxlight commented 1 year ago

Sure

On Sat, 12 Nov 2022, 3:53 am João Vitor, @.***> wrote:

How hard would it be to implement the conversion of ttk.ComboBox https://docs.python.org/3/library/tkinter.ttk.html#combobox? It works like a dropdown and it's a subclass of Entry, which is already implemented. Are there any plans to add more elements? I could work on this!

— Reply to this email directly, view it on GitHub https://github.com/Proxlight/Proxlight-Designer-v2/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQU322CVRLOPTHUN4YQRBQDWH3BPXANCNFSM6AAAAAAR57MZDE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Proxlight commented 1 year ago

Yes you can add it

joao-vitor-souza commented 1 year ago

Nvm, I implemented it, but tbh it looks very ugly, it does not have parameteres like highlightthickness or bg. OptionMenu, which is another dropdown element from Tkinter, also doesn't have them. So, it's not worth it to put this in production.

Proxlight commented 1 year ago

But you can still pull a request I will try to fix it