search

Proxmark / proxmark3

Proxmark 3
http://www.proxmark.org/
GNU General Public License v2.0
3.09k stars 901 forks source link

v3.0.1 #314

Closed iceman1001 closed 7 years ago

iceman1001 commented 7 years ago

Since the compilation errors for some envs has been fixed; I suggest a minor new release. I've started the draft, feel free to update it with text. I also think we can add the "hitag2" PR before we release.

Link to draft https://github.com/Proxmark/proxmark3/releases/tag/untagged-0101d2f2c7af775951c4

pwpiwi commented 7 years ago

I thought as well. This would finally be a working release for the homebrew tap.

CHANGELOG.md should be up to date before releasing.

iceman1001 commented 7 years ago

Something you will sort out now?

marshmellow42 commented 7 years ago

There are some new high impact coverity issues indicated with the hardnested and some other code I think should be addressed first.

marshmellow42 commented 7 years ago

The more I think on it fixing all the coverity scan issues will take time, once complete we should do another release, but the recent fixes warrants a release now as well.

pwpiwi commented 7 years ago

CHANGELOG.md updated. Regarding the hitag2 PR I would prefer to have it tested by someone before merging.

iceman1001 commented 7 years ago

Neither marshmellow or I have access to hitag2 tags. If you (piwi) don't, we have to find someone who has. I believe someone contacted me about it. I'll check and see if I can get hold of that user to test it out for us.

iceman1001 commented 7 years ago

So, with @marshmellow42 latest PR merge. Where are we on this one?

marshmellow42 commented 7 years ago

I'm not aware of any other compatibility issues. I'm going to work on a few coverity issues, but they aren't high impact.

iceman1001 commented 7 years ago

and @pwpiwi ?

Still no news about Hitag2 write PR.

marshmellow42 commented 7 years ago

before potentially breaking(low probability) the repo with new functionality (hitag2 write) i think we should go ahead with 3.0.1 release and then update the homebrew tap to use that release by default.

then we can go from there.

marshmellow42 commented 7 years ago

unless pwpiwi has something more to add/fix first..

iceman1001 commented 7 years ago

I've some minor fixes to hardnested.. But with my fork, I can't push PRs.
I mailed @pwpiwi about it.

marshmellow42 commented 7 years ago

you need a branch that is at the master head. :p

On Fri, Jun 9, 2017 at 11:07 AM, Iceman notifications@github.com wrote:

I've some minor fixes to hardnested.. But with my fork, I can't push PRs. I mailed @pwpiwi https://github.com/pwpiwi about it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Proxmark/proxmark3/issues/314#issuecomment-307414746, or mute the thread https://github.com/notifications/unsubscribe-auth/AJPQdFfG_ooDE-fy8GHHuKsiwy2YwUX7ks5sCV_AgaJpZM4Nz5TN .

iceman1001 commented 7 years ago

Despite what ppl think of me, I'm not that good at Git. So I can make a branch based on pm3 master?!? I didn't know that. Third thing I learned today

pwpiwi commented 7 years ago

Let's go for it. Seems to be quite settled as it is.

iceman1001 commented 7 years ago

Ok. tag v3.0.1 is created. I've also made a PR for the homebrew repo.