Closed Fl0-0 closed 7 years ago
@marshmellow42: with iclass code being the only relevant part being changed after v3.0.1, can you please have a look? hf search
calls HFiClassReader("", false, false)
in https://github.com/Proxmark/proxmark3/blob/ebe9a3ba04eead5832879355434c20f78b33d7b2/client/cmdhf.c#L671. Is it possible that it never returns? Suspect line: https://github.com/Proxmark/proxmark3/blob/ebe9a3ba04eead5832879355434c20f78b33d7b2/armsrc/iclass.c#L1766
second sample from @Fl0-0 shows a working hf search and hf 15 cmd inqury
For me, the tag position is vital. Making hf search miss iso15693 tag quite often.
Hello, I've commented the iClass part in CmdHFSearch(), it works again and never miss the tag !
/*
ans = HFiClassReader("", false, false);
if (ans) {
PrintAndLog("\nValid iClass Tag (or PicoPass Tag) Found - Quiting Search\n");
return ans;
}
*/
Prox/RFID mark3 RFID instrument
bootrom: master/v2.2.0-552-gebe9a3b-suspect 2017-07-04 15:43:52
os: master/v2.2.0-552-gebe9a3b-suspect 2017-07-04 15:43:53
LF FPGA image built for 2s30vq100 on 2015/03/06 at 07:38:04
HF FPGA image built for 2s30vq100 on 2017/05/17 at 17:48:26
uC: AT91SAM7S256 Rev B
Embedded Processor: ARM7TDMI
Nonvolatile Program Memory Size: 256K bytes. Used: 193020 bytes (74%). Free: 69124 bytes (26%).
Second Nonvolatile Program Memory Size: None
Internal SRAM Size: 64K bytes
Architecture Identifier: AT91SAM7Sxx Series
Nonvolatile Program Memory Type: Embedded Flash Memory
proxmark3> hf search
Tag UID : E004020052B53DE2
Tag Info: NXP(Philips); IC SL2 ICS53/ICS54(SLI-S) ICS5302/ICS5402(SLIX-S)
Valid ISO15693 Tag Found - Quiting Search
As @Fl0-0 already mentioned that the current firmware is OK, I am now suspecting https://github.com/Proxmark/proxmark3/blob/ebe9a3ba04eead5832879355434c20f78b33d7b2/client/cmdhficlass.c#L195 as being the culprit. @marshmellow42 ?
Yeah, but this is the old code which probably had been changed by @marshmellow42 for a good reason. I am not completely sure about the reason for the change in this line but I think that
if (readStatus == 0 && !loop) {
// Aborted
if (verbose) PrintAndLog("Quitting...");
return 0;
}
should do the trick.
Sorry was sleeping. ;). Yes @pwpiwi s code should do the trick. I can do a pull request later if no one beats me to it.
there are other issues here as well. i'm working on a fix.
hf search works fine with all my tags now, thanks !
hf search does not detect 15693 cards correctly anymore
Bug probably in client code:
LED A flashes continuously, tag not found. Reset the proxmark and hf 15 cmd inquiry works