Proxying / TabManager

Allows Sponge servers to fully customize their tab lists.
11 stars 8 forks source link

Formatting Issue with PlaceholderAPI #17

Open Foxtrek64 opened 5 years ago

Foxtrek64 commented 5 years ago

Description Coming from Paper, I was hoping to bring over some of the functionality that I had there. As seen in the screenshot below, I am using NametagEdit and PlaceholderAPI to show my nickname, my rank (the red +), and my actual username. Before the username is also the suffix but it's not visible - I use that for donator rank colors. Placeholders here replace for each player entry - that is, Steve has his placeholders, Notch has his, Alyx has hers, and so forth. 2019-02-13_18 01 36

Installing PlaceholderAPI and TabManager, I set out to implement the same functionality. Here is my config file:

"DEFAULT": {
  "name": "default",
  "prefix": "&7%player_suffix%(",
  "suffix": ") %player_prefix%&f%player_displayname%"
}

Issue When in game, the PlaceholderAPI replacements are performed for the person viewing the tab list, not the player in that line of the tab list. This leads to strange behavior like seen in the screenshots below, one from me and one from one of my moderators.

moderator pov 2019-02-13_17 38 26

Additionally, it would seem that the %player_displayname% placeholder is showing my username and not my nickname, despite having a nickname set with Nucleus.

Additional Information Versions: Minecraft Version: Minecraft 1.12.2 Sponge Version: SpongeForge 1.12.2-2768-7.1.5 Sponge API Version: SpongeAPI 7.1.0-366290f8 Nucleus Version: 1.8.2-S7.1 (Git: edc19584) PlaceholderAPI (placeholderapi) version 4.5.1 TabManager (tabmanager) version 2.1.3-S7.0-MC1.12.2

Proxying commented 5 years ago

Currently the way it's setup (showing the viewer of the tab menu their specific placeholders) is intended. However this was mainly written for the header/footer. I could see about switching up the individual player entries to fill placeholders related to those players.

As for the %player_displayname% not showing nickname, that's something that PlaceHolderAPI would have to change.

Foxtrek64 commented 5 years ago

Please do so. Due to the nature of my server, I need the players' real names visible at a glance.

I will create a sister issue on their github, or wherever they are accepting issues.

Foxtrek64 commented 5 years ago

Just going to reference the sister issue for easy back-and-forth navigation.