ProxymanApp / Proxyman

Modern. Native. Delightful Web Debugging Proxy for macOS, iOS, and Android ⚡️
https://proxyman.io
5.34k stars 177 forks source link

`Buy Proxyman Pro` Menu Bar Button Does Nothing if All Proxyman Windows Have Been Closed (but app still runs) #2018

Open ptrkstr opened 1 month ago

ptrkstr commented 1 month ago

Description

Proxyman is a very well designed macOS app. I've been referencing it as I'm improving my macOS app (https://lyrcs.app). I wanted to mimic Proxyman's pattern of showing the PRO window when user presses Menu > Proxyman > Buy Proxyman Pro.... I discovered however nothing appears if no window is available which is because Proxyman presents a modal sheet over a window. I expect this to be a minor case because how often would a user use Proxyman without a window open. Regardless I thought it would be interesting to see how you solved it as perhaps I could solve it in a similar way.

Steps to Reproduce

  1. Open Proxyman
  2. Close window (CMD + W)
  3. Menu > Proxyman > Buy Proxyman Pro...

Current Behavior

Nothing occurs

Expected Behavior

I receive information about Proxyman Pro.

Environment

Possible Solutions

NghiaTranUIT commented 1 month ago

Thanks for using Proxyman as a reference source.

I'd follow: if there is a windows -> shows as modal, if not, just present as a normal Windows.

It's easier from user's point of view. Just click and it opens

ptrkstr commented 1 month ago

Good idea, makes the most sense and achievable with SwiftUI Window and @Environment(\.openWindow) API, thanks!