forEach in checkAll() and asynchronous operations in callback

[trekze]

We've upgraded from a much older version version of detect-collisions, and it's mostly working as intended, aside for some rare race condition-like symptoms. Our handlecollisions callback has async calls in it at times. Wondering if this might be caused by checkAll() using foreach internally instead of for...of. Is it possible this might cause several of the callbacks to be called in parralel?

Thanks for your help. Amazing library.

[Prozi]

Is it possible this might cause several of the callbacks to be called in parralel?

as far as I know javascript can't really execute something out of the box in paralel since its single threaded :)

I am not sure I know what you mean, can you provide me with some minimal sample of code?

[trekze]

Resolved by using our own loop and using getPotentials and checkCollision instead.

Javascript is single threaded, but asynchronous. So if you use an await in the checkAll() callback, you may get interleaved execution of multiple calls to the callback.

For example is the callback is something like:

{
A
B
await someAsyncFunction()
C
D
}

You could get the following execution path (if it's called twice):

A B A B C D C D

Which can cause race conditions. Hope that makes. Resolved with workaround anyway so no need for changes for us.

[Prozi]

Resolved by using our own loop and using getPotentials and checkCollision instead.

I am glad you got it to work!

Which can cause race conditions. Hope that makes. Resolved with workaround anyway so no need for changes for us.

Yeah that makes sense, thank you for the explanation

may I close the issue now?

[trekze]

Sure