PruneTruong / DenseMatching

Dense matching library based on PyTorch
GNU Lesser General Public License v2.1
689 stars 81 forks source link

Some questions about the supervise loss #17

Closed JiangHai0929 closed 2 years ago

JiangHai0929 commented 2 years ago

Hi, I have some questions about the supervise loss as follows; _ss_loss_o, ss_stats_o = self.objective(estimated_flow_target_prime_to_target_directly, mini_batch['flow_map'], mask=minibatch['mask'], the mini_batch['flow_map'] is the ground-truth flow you generate in the online_triplet_creation.py (_flow_gt = self.synthetic_flow_generator(mini_batch=minibatch, training=training, net=net)) and the target image prime is warped by using the flow_gt, so the mini_batch['flow_map'] should be _flow_target_to_target_primedirectly, why you caclulate the L1 distance between _estimated_flow_target_prime_to_target_directly and mini_batch['flowmap'] rather than the distance between _estimated_flow_target_to_target_prime_directly and mini_batch['flowmap']. Thanks, Looking forward to your reply!

PruneTruong commented 2 years ago

Hey, so I assume you answered your question? :)

JiangHai0929 commented 2 years ago

yes, i made a mistake, thank you!