search

Pryaxis / TSAPI

🛠🌳 The TShock Scaffold API enables developers to build plugins that hook directly into the Terraria game engine.
http://tshock.co/
GNU General Public License v3.0
109 stars 66 forks source link

Regression: Not possible to run bootstrapper with 1 click in VS2017 #156

Closed hakusaro closed 6 years ago

hakusaro commented 6 years ago

A change introduced in 1ebf418459a2809ee2fa85486aff1e9f074666d4 requires an env.config to be present in the build folder in order to run the bootstrapper in one click. It looks like a55a1787803abd50fbae98d093c7a3cbf19c5297 should have enabled a pre-build event that would create the env.config file in the output directory, but it doesn't do that on VS2017. I have no idea what causes this -- I'm not a Visual Studio person -- but the result is pretty clear: you can't 1-click run the bootstrapper anymore.

As part of https://github.com/Pryaxis/TShock/pull/1558 I'm trying to document the build process. Right now I have to write an extra instruction to build the bootstrapper, make an env.config and then run it, which is a stupid amount of friction to go through. This needs to be a 1-click event because the process is already complicated enough as it is, between submodules, nuget, patchers, and more builds.

I'm marking this as high importance because it currently breaks the build instructions that we have officially published. This needs to be resolved as soon as possible.