search

Pryaxis / TSAPI

🛠🌳 The TShock Scaffold API enables developers to build plugins that hook directly into the Terraria game engine.
http://tshock.co/
GNU General Public License v3.0
109 stars 66 forks source link

TEItemFrame doesn't load or send properly. #50

Closed pilihp64 closed 8 years ago

pilihp64 commented 8 years ago

When TerrariaAPI-Server loads a world with a TEItemFrame, clients connected will not receive that "section" of the map, leaving a void.

Place an item in an Item frame in single player and save the world, load this world with a recent TerrariaAPI-Server and connect. The area with the TEItemFrame is now a void as it appears to the character. This could be a loading problem, or a network sending problem leaving the section blank.

This happens regardless of any plugins including TShock.

AxisKriel commented 8 years ago

Does this work on vanilla TerrariaServer? Could be a bug on their end.

pilihp64 commented 8 years ago

Yes the normal server works as expected, it syncs properly and items can be placed and taken from Item frames.

Item frames themselves can be placed on TerrariaAPI, but you can't place anything inside the frame (nothing happens at all). So it makes sense that something is wrong with the entity responsible for that on the server.

AxisKriel commented 8 years ago

Please attempt to reproduce with the latest changes.

pilihp64 commented 8 years ago

No it still does not seem to function in any way, same symptoms.

AndrioCelos commented 8 years ago

I've seen the same issue with all tile entities.

pilihp64 commented 8 years ago

I compared Entity functions with my personal decompile where Entities worked, found a loading mistake where they were never initialized.

AxisKriel commented 8 years ago

So is this fixed now? Let me know if I can close this issue.

pilihp64 commented 8 years ago

Yes, fixed as far as I've tested.