search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

I smell something very bad with these ID's.. #1207

Closed tlworks closed 8 years ago

tlworks commented 8 years ago

2016-06-03 19:42:34 - Utils: INFO: OFF executed: /itemban add 3706. 2016-06-03 19:42:35 - ItemManager: ERROR: MySql.Data.MySqlClient.MySqlException (0x80004005): Duplicate entry 'Platinum Bow' for key 'PRIMARY' at MySql.Data.MySqlClient.MySqlStream.ReadPacket() at MySql.Data.MySqlClient.NativeDriver.GetResult(Int32& affectedRow, Int64& insertedId) at MySql.Data.MySqlClient.Driver.GetResult(Int32 statementId, Int32& affectedRows, Int64& insertedId) at MySql.Data.MySqlClient.Driver.NextResult(Int32 statementId, Boolean force) at MySql.Data.MySqlClient.MySqlDataReader.NextResult() at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior) at MySql.Data.MySqlClient.MySqlCommand.ExecuteNonQuery() at TShockAPI.DB.DbExt.Query(IDbConnection olddb, String query, Object[] args) at TShockAPI.DB.ItemManager.AddNewBan(String itemname)

Should I consider even banning these?

tlworks commented 8 years ago

Considering the fact the server things the item is a platinum bow.

AxisKriel commented 8 years ago

https://github.com/NyxStudios/TerrariaAPI-Server/blob/general-devel/Terraria/ID/ItemID.cs#L7429 That's certainly weird. In our code base that's a fake chest.

AxisKriel commented 8 years ago

sbplanet co_-_remote_desktop_connection_2016-06-04_02-19-20 No name, huh.. I believe @WhiteXZ to have asked yor if there was an issue with those two items, fakechest1 and 2, but he never answered.

tlworks commented 8 years ago

@Enerdy I noticed upon having the Chestroom plugin and editing the source to add up to every ID, opening the last chest in the Chestroom will show those two items as blueberry seeds and seaweed but if you try to place them nothing happens (apart from showing a chest which doesn't exist in Terraria yet, a whole new kind of chest) and it somehow slightly changes your armor look upon trying to place it.

QuiCM commented 8 years ago

These items are broken and can no longer be placed in a TShock server.