"Invalid command entered" when no command entered

[OnsenManju]

Maybe this was caused by fixing security issues(?), error message is also displayed when I just pressed 'Enter' key (or whitespace only). It's a bit annoying.

Is there any way to avoid this, something like

if (cmdText.Trim() == "") { return true; }

at HandleCommand() in TShockAPI/Commands.cs?

[ivanbiljan]

I do not see this as an issue honestly, if you're using the command specifier you want to enter a command by some logic, and if you don't type the command correctly or specify the command at all it returns an "Invalid command" message.

[hakusaro]

@ProfessorXZ that's the console, though which expects a command on any line with no specifier at all

[ivanbiljan]

If it doesn't cause problems on the client what's the issue? Isn't this how the console always worked?

[Simon311]

@ProfessorXZ Empty commands were ignored. Though I am not sure how this is an issue.

[Simon311]

I will include this fix in an upcoming pull request.

[OnsenManju]

Thanks everyone for considering this. I was using "null line" for separating logs displayed on console screen in order to making clearly understandable when examining behavior of plugin (e.g. testing commands one by one) etc. so far.

So this is not critical at all, just 'a bit' inconvenient.

[Simon311]

@OnsenManju If this is of any urgency - you may grab the build with this fix here https://travis.tshock.co/general-devel/1321/tshock_release.zip

[OnsenManju]

@Simon311 I have tried that. (Though there is no urgency regarding this, of course)

• null line doesn't display any errors
• simple "Invalid command" message for whitespaces
• red "Invalid command entered" error for actual invalid commands

That's very legitimate, thanks so much!

[hakusaro]

The "Invalid command." is probably a vanilla message.

[OnsenManju]

Oh, that's exactly right. It's same as the original TerrariaServer.exe (not TShock). I have never hosted a server with it.. ^_^;;