Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

ChatAboveHeads causes black magic on non-SSC Servers. #1436

Closed tlworks closed 7 years ago

tlworks commented 7 years ago

What other people see when people talk; https://i.gyazo.com/49ee8398f7c9b968b87d27d34f94a745.png

What you see on your own name when you talk; https://i.gyazo.com/b0d5d27fc52ef4230c1438eaa2ae1e34.png

Basically when ChatAboveHeads is enabled in an non-SSC Server, your prefixes don't show up in your own Chat. If this works without Plugins (haven't tested myself yet) please let me know or close this issue.

tlworks commented 7 years ago

Tested on TShock without Plugins and still occurs.

QuiCM commented 7 years ago

@tlworks Did you set your ChatAboveHeadsFormat in your config file? terraria_2017-05-03_15-17-27 First line is default format ("{2}") Second line is "{1}{2}{3}"

tlworks commented 7 years ago

I've set it to; "ChatFormat": "{1}{2}{3} {4}", "ChatAboveHeadsFormat": "{1}> {2} <{3}", Because it doesn't (or didn't) work otherwise with suffix & prefixes, though it makes no difference since it works on SSC but not on NSSC locally for the player.

QuiCM commented 7 years ago

My screenshot was non-SSC

tlworks commented 7 years ago

So I would have to set ChatFormat to {2} only?

QuiCM commented 7 years ago

ChatFormat doesn't effect sent chat when ChatAboveHeads is enabled currently. This is an oversight that needs to be fixed

QuiCM commented 7 years ago

528d9c6 should solve this - awaiting confirmation

tlworks commented 7 years ago

Rather than posting it in a comment section;

In case this will be forgotten, this breaks the current (and awesome) way of ChatAboveHeads in SSC (NSSC?) where the Chat also shows above the player themselves, this was a neat and a long awaited feature/fix.

Would be great if this could be added again.

@WhiteXZ

ivanbiljan commented 7 years ago

Closing this as the main issue has been fixed by @QuiCM