TileKill permission check is Easily Bypassed

[Ristellise]

• TShock version: TShock v4.3.25 for Terraria 1.3.5.3
• TShock build number (if known): N/A

Reproduction steps (if applicable)?

1. Install TerrariaPatcher
2. Patch Terraria
3. Enter into tshock server with axe and pick in hand
4. Level the terrain in a few hours.

Any stack traces or error messages (if known)?

Video (Thanks to hakusaro for uploading.)

Trees? What Trees?

[hakusaro]

This absolutely needs to be fixed as soon as possible.

[Ristellise]

If you continue to break blocks quickly for too long, you will eventually get disabled by server. However, the server takes too long to realise your breaking blocks far too quickly.

Source for the TerrariaPatcher Plugin

[hakusaro]

After discussion with @ivanbiljan, this is going to be left to a plugin to implement a fix for or mitigation against. My current suggestion is to set tile kill thresholds on a per axe/per weapon basis, and combine that with range checks to mitigate these types of tile kills. A tile kill threshold per set of tools or a tile kill threshold that's more tailored to how a user interacts with the game is a better way to go than relying on TShock to continually keep its thresholds up to date.