Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

464' and 466' tiles placement may cause StackOverflowException between WorldGen.TileFrame() and WorldGen.Check5x4() #1637

Open IEEERemainder opened 5 years ago

IEEERemainder commented 5 years ago

TShock version: 4.3.25, API v2.1, OTAPI v2.0.0.27

Stack Trace: default

Reproduction steps: It was too hard to locate a problem, only traffic dump analysis allows to define that.

  1. Build 5 block width platform from solid blocks.
  2. Use custom client or terraria patcher to use NetMessage.SendData(17, -1, -1, 1, (float)x, (float)y, 466f, 0, 0, 0) where (x, y) = coordinates of the middle block above the platform. default

Result: default

bartico6 commented 5 years ago

Confirming that it has happened countless times, we had it with 3x2 furniture when players attempted to overwrite a part of a furniture block with cheats.

This is effectively a Terraria problem, not really something you can blame TShock for.

AxeelAnder commented 5 years ago

I did it but nothing happened, do you mind giving me your client/TerrariaPatcherPlugin?

AxeelAnder commented 4 years ago

Confirmed before. It might be caused by image Not sure though

Kingdomffff commented 1 year ago

Me understands a little bit of coding also me i fucking hate geometry